Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 385efdd001
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| arrow-schema = { workspace = true } | ||
| async-compression = { version = "0.4.36", features = ["tokio", "zstd"] } | ||
| bollard = { version = "0.19" } | ||
| bollard = { version = "0.20" } |
There was a problem hiding this comment.
Keep container response import compatible with bollard 0.20
Upgrading to bollard 0.20 pulls in the secret-module change that removed model re-exports, but this crate still imports ContainerCreateResponse from bollard::secret (lading/src/generator/container.rs:12). With 0.20.x that path is no longer exported, so builds fail until the import is migrated to bollard::models::ContainerCreateResponse (or the dependency bump is deferred).
Useful? React with 👍 / 👎.
Bumps [bollard](https://github.com/fussybeaver/bollard) from 0.19.4 to 0.20.2. - [Release notes](https://github.com/fussybeaver/bollard/releases) - [Changelog](https://github.com/fussybeaver/bollard/blob/master/RELEASE.md) - [Commits](fussybeaver/bollard@v0.19.4...v0.20.2) --- updated-dependencies: - dependency-name: bollard dependency-version: 0.20.2 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
385efdd to
d788ced
Compare
Bumps bollard from 0.19.4 to 0.20.2.
Release notes
Sourced from bollard's releases.
... (truncated)
Commits
ddd2171chore: Release 0.20.2 (#696)05c59e8fix(secrets): Remove re-export of models (#695)811dfd0feat: add attach_container_websocket API for WebSocket container attach (#689)e7e32f1chore: Release 0.20.1 (#688)3a21837build(deps): bump swagger-codegen.version in /codegen/swagger (#608)8469302build(deps): bump rust from 1.92.0-slim to 1.93.0-slim (#684)177d2aeAdd Docker::connect_with_host (#685)cfb11d1chore: bump bollard-stubs dependency (#686)e70f072build: drop serde_with dep (#682)73fcfadrelease: v0.20.0 (#679)