Migrate from regex to regex-lite #1232
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1232 +/- ##
==========================================
+ Coverage 71.65% 71.96% +0.31%
==========================================
Files 354 368 +14
Lines 56063 58118 +2055
==========================================
+ Hits 40172 41826 +1654
- Misses 15891 16292 +401
🚀 New features to boost your workflow:
|
BenchmarksComparisonBenchmark execution time: 2025-10-27 23:16:12 Comparing candidate commit c23f2e6 in PR branch Found 1 performance improvements and 14 performance regressions! Performance is the same for 38 metrics, 2 unstable metrics. scenario:concentrator/add_spans_to_concentrator
scenario:credit_card/is_card_number/37828224631000521389798
scenario:credit_card/is_card_number_no_luhn/ 378282246310005
scenario:credit_card/is_card_number_no_luhn/378282246310005
scenario:credit_card/is_card_number_no_luhn/37828224631000521389798
scenario:ip_address/quantize_peer_ip_address_benchmark
scenario:normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000...
scenario:normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters
scenario:tags/replace_trace_tags
CandidateCandidate benchmark detailsGroup 1
Group 2
Group 3
Group 4
Group 5
Group 6
Group 7
Group 8
Group 9
Group 10
Group 11
Group 12
Group 13
Group 14
Group 15
BaselineOmitted due to size. |
Aaalibaba42
force-pushed
the
jwiriath/regex-to-regex-lite
branch
from
87e6cfa to
b9ee66d
Compare
|
tools:
datadog-trace-obfuscation:
ddcommon:
datadog-live-debugger:
data-pipeline:
|
|
https://gitlab.ddbuild.io/DataDog/apm-reliability/libddprof-build/-/jobs/1140399351 Job for size benchmark failed, so I'm pasting the results here: Artifact Size Benchmark Reportaarch64-alpine-linux-musl
aarch64-unknown-linux-gnu
libdatadog-x64-windows
libdatadog-x86-windows
x86_64-alpine-linux-musl
x86_64-unknown-linux-gnu
|
|
|
||
| [dependencies] | ||
| regex = "1" | ||
| regex-lite = "^0.1" |
There was a problem hiding this comment.
"^0.1" is equivalent to "0.1" so you don't really need to add it
https://doc.rust-lang.org/cargo/reference/specifying-dependencies.html#caret-requirements
Also you should probably add it as a workspace dependencies, with a minimum constraint to the highest minor available ("0.1.7" right now)
There was a problem hiding this comment.
What about instances where it is likely using a whole regex engine (even the lite one) is superfluous as described in this comment: #1232 (comment)
Is it worth exploring ? Would it be a separate PR ?
|
There is also the potential pitfall of Unicode support: One of the corners cut by regex-lite to be smol was to sacrifice a little correctness, notably around Unicode support. In the instances where this PR changes regex to regex-lite:
|
Aaalibaba42
force-pushed
the
jwiriath/regex-to-regex-lite
branch
2 times, most recently
from
aee876a to
8d550b8
Compare
Aaalibaba42
force-pushed
the
jwiriath/regex-to-regex-lite
branch
from
8d550b8 to
42aaebb
Compare
|
Please check out this subproject (especially the readme) for information about the change |
Aaalibaba42
force-pushed
the
jwiriath/regex-to-regex-lite
branch
from
71fad1e to
6447fee
Compare
Aaalibaba42
force-pushed
the
jwiriath/regex-to-regex-lite
branch
from
6447fee to
c23f2e6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Migrate from the
regexcrate toregex-lite.Motivation
The
regexcrate is very fast, but takes up lots of space in the binaries.regex-litemight introduce regression in performance, but we should see it's much more optimized in space.How to test the change?
There is (I believe so) a benchmark on the size of the artifacts (and the performance). We can evaluate if this change is worth it based on those.