-
Notifications
You must be signed in to change notification settings - Fork 15
[crashtracking] upload to both telemetry intake and errors intake #1259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
BenchmarksComparisonBenchmark execution time: 2025-11-03 01:16:14 Comparing candidate commit d45b1fd in PR branch Found 2 performance improvements and 1 performance regressions! Performance is the same for 52 metrics, 2 unstable metrics. scenario:normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo...
scenario:redis/obfuscate_redis_string
CandidateCandidate benchmark detailsGroup 1
Group 2
Group 3
Group 4
Group 5
Group 6
Group 7
Group 8
Group 9
Group 10
Group 11
Group 12
Group 13
Group 14
Group 15
Group 16
Group 17
BaselineOmitted due to size. |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1259 +/- ##
==========================================
+ Coverage 72.11% 72.21% +0.10%
==========================================
Files 368 370 +2
Lines 58111 58952 +841
==========================================
+ Hits 41907 42575 +668
- Misses 16204 16377 +173
🚀 New features to boost your workflow:
|
|
✅ Tests 🎉 All green!❄️ No new flaky tests detected 🔗 Commit SHA: d45b1fd | Docs | Datadog PR Page | Was this helpful? Give us feedback! |
Artifact Size Benchmark Reportaarch64-alpine-linux-musl
aarch64-unknown-linux-gnu
libdatadog-x64-windows
libdatadog-x86-windows
x86_64-alpine-linux-musl
x86_64-unknown-linux-gnu
|
7a55094 to
d42530c
Compare
74a5f22 to
9e55d5f
Compare
fca11ec to
af27f4b
Compare
23cc5f8 to
d8a46d6
Compare
|
TODOs:
|
d39b44b to
7211c87
Compare
|
TODO: Needs to be a flag for the whole feat. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM after this tiny change
fb5b7bb to
e58f1f4
Compare
ec87afc to
c235ddf
Compare
c235ddf to
d45b1fd
Compare

What does this PR do?
With the new Errors intake, we want to support dual uploads to Errors intake and the current telemetry intake
Motivation
What inspired you to submit this pull request?
Additional Notes
Errors Intake endpoints and conditions; this was largely follows how
TelemetryhandlesCrashInfouploadsHow to test the change?
Unit tests
Run a tracer that points to the latest commit on this PR for libdatadog locally and crash a program
https://dd.datad0g.com/error-tracking?query=service%3Atest_app&fromUser=false&order=first_seen&refresh_mode=sliding&source=all&from_ts=1759843044695&to_ts=1760447844695&live=true