-
Notifications
You must be signed in to change notification settings - Fork 15
Prevent checking for a specific version since crates version can change. #1280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
2096a26 to
48fdcda
Compare
BenchmarksComparisonBenchmark execution time: 2025-10-27 19:09:23 Comparing candidate commit 7380a63 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 55 metrics, 2 unstable metrics. CandidateCandidate benchmark detailsGroup 1
Group 2
Group 3
Group 4
Group 5
Group 6
Group 7
Group 8
Group 9
Group 10
Group 11
Group 12
Group 13
Group 14
Group 15
Group 16
Group 17
BaselineOmitted due to size. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1280 +/- ##
==========================================
+ Coverage 71.80% 71.92% +0.11%
==========================================
Files 368 368
Lines 57967 58150 +183
==========================================
+ Hits 41626 41824 +198
+ Misses 16341 16326 -15
🚀 New features to boost your workflow:
|
Artifact Size Benchmark Reportaarch64-alpine-linux-musl
aarch64-unknown-linux-gnu
libdatadog-x64-windows
libdatadog-x86-windows
x86_64-alpine-linux-musl
x86_64-unknown-linux-gnu
|
What does this PR do?
Prevent tests from checking for a specific version in libdatadog_version field.
Motivation
Since we're going to versioning individual crates the ffi crate's version doesn't have to match the implementation one.