-
Notifications
You must be signed in to change notification settings - Fork 15
Versioning/Publishing Milestone 1 #1283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
✅ Tests 🎉 All green!❄️ No new flaky tests detected 🔗 Commit SHA: 3150ac7 | Docs | Datadog PR Page | Was this helpful? Give us feedback! |
BenchmarksComparisonBenchmark execution time: 2025-11-03 10:06:25 Comparing candidate commit 3150ac7 in PR branch Found 0 performance improvements and 9 performance regressions! Performance is the same for 46 metrics, 2 unstable metrics. scenario:normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo...
scenario:normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000...
scenario:normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters
scenario:normalization/normalize_service/normalize_service/[empty string]
scenario:sql/obfuscate_sql_string
CandidateCandidate benchmark detailsGroup 1
Group 2
Group 3
Group 4
Group 5
Group 6
Group 7
Group 8
Group 9
Group 10
Group 11
Group 12
Group 13
Group 14
Group 15
Group 16
Group 17
BaselineOmitted due to size. |
…dog-profiling-protobuf
e126dfc to
88607c4
Compare
d655085 to
8bc54b1
Compare
Artifact Size Benchmark Reportaarch64-alpine-linux-musl
aarch64-unknown-linux-gnu
libdatadog-x64-windows
libdatadog-x86-windows
x86_64-alpine-linux-musl
x86_64-unknown-linux-gnu
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1283 +/- ##
==========================================
- Coverage 72.03% 71.67% -0.37%
==========================================
Files 369 369
Lines 58241 58276 +35
==========================================
- Hits 41953 41767 -186
- Misses 16288 16509 +221
🚀 New features to boost your workflow:
|
libdd-common-ffi/README.md
Outdated
| - **String Utilities**: Safe string handling across FFI | ||
| - **Vec Types**: C-compatible vector types | ||
| - **Slice Types**: Safe slice handling | ||
| - **Memory Management**: RAII-style memory management for C |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure this RAII-style is really true? Sounds like AI hallucination
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed
What does this PR do?
libdd-{member}(builder,tools*,spawn_worker,symbolizer-ffi,testsandbin_testshave been left as they were)publish=falseREADME.mdfiles generated with IA (reviewed very briefly) from the rust docs.Motivation
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?
How to test the change?
Describe here in detail how the change can be validated.