crashtracker: verify unix socket peer uid before parsing reports#1968
Draft
paullegranddc wants to merge 1 commit into
Draft
crashtracker: verify unix socket peer uid before parsing reports#1968paullegranddc wants to merge 1 commit into
paullegranddc wants to merge 1 commit into
Conversation
Contributor
📚 Documentation Check Results📦
|
Contributor
Clippy Allow Annotation ReportComparing clippy allow annotations between branches:
Summary by Rule
Annotation Counts by File
Annotation Stats by Crate
About This ReportThis report tracks Clippy allow annotations for specific rules, showing how they've changed in this PR. Decreasing the number of these annotations generally improves code quality. |
Contributor
🔒 Cargo Deny Results📦
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1968 +/- ##
==========================================
- Coverage 72.63% 72.60% -0.03%
==========================================
Files 448 448
Lines 73582 73598 +16
==========================================
- Hits 53444 53437 -7
- Misses 20138 20161 +23
🚀 New features to boost your workflow:
|
🎉 All green!❄️ No new flaky tests detected 🎯 Code Coverage (details) 🔗 Commit SHA: 00737fa | Docs | Datadog PR Page | Give us feedback! |
Contributor
Artifact Size Benchmark Reportaarch64-alpine-linux-musl
aarch64-unknown-linux-gnu
libdatadog-x64-windows
libdatadog-x86-windows
x86_64-alpine-linux-musl
x86_64-unknown-linux-gnu
|
pawelchcki
reviewed
May 11, 2026
| ) -> anyhow::Result<()> { | ||
| let (unix_stream, _) = listener.accept().await?; | ||
| #[cfg(target_os = "linux")] | ||
| ensure_same_user(&unix_stream)?; |
Contributor
There was a problem hiding this comment.
It would be good to add tests verifying the new enforcement
Contributor
|
This assumes that the scripts themselves don't execute set(e)uid() as part of their normal execution. (e.g. with the sidecar, the sidecar spawns at startup, but crashtracker gets its dedicated socket, which would now fail to access.) |
Contributor
Author
Then maybe instead of checking uid, it could be interesting to check that the connecting process either is the parent process, or has the same parent process as the crashtracker |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
ensure_same_userthat usesgetsockopt(..., SO_PEERCRED, ...)to obtain the peerucredand compares the peer UID to the receiver effective UID vialibc::geteuid().async_receiver_entry_point_unix_listenerbefore any parsing of the incoming crashreport stream.AsRawFdfor access to the accepted socket file descriptor and kept the change confined tolibdd-crashtracker/src/receiver/entry_points.rsto minimize surface area.Testing
cargo fmt --alland formatting completed successfully.cargo test -p libdd-crashtracker --no-runwhich compiled the crate tests successfully (tests were prepared but not executed) and completed without build errors.Codex Task