test(browser): execute packed package in Chromium - #366
Merged
sameerank merged 3 commits intoAug 13, 2026
Merged
Conversation
leoromanovsky
commented
Aug 13, 2026
There was a problem hiding this comment.
Pull request overview
Adds real Chromium runtime smoke coverage for packed browser artifacts introduced by #344.
Changes:
- Builds full and precomputed Vite entry points.
- Tests parsing, evaluation, serialization, fallbacks, and browser errors.
- Installs Chromium and runs Playwright during package validation.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
test-app/vite.config.ts |
Configures multi-page production builds. |
test-app/tests/smoke.spec.ts |
Adds Chromium smoke tests. |
test-app/src/smoke.ts |
Provides smoke assertions and result reporting. |
test-app/src/precomputed.ts |
Exercises the precomputed entry point. |
test-app/src/main.ts |
Exercises full configuration parsing and evaluation. |
test-app/precomputed.html |
Hosts the precomputed fixture. |
test-app/playwright.config.ts |
Configures Chromium and Vite preview. |
test-app/package.json |
Adds Playwright tooling and script. |
test-app/index.html |
Simplifies the full-entry fixture page. |
scripts/test-package-install.sh |
Runs browser tests against packed artifacts. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
leoromanovsky
marked this pull request as ready for review
August 13, 2026 20:39
leoromanovsky
requested review from
btthomas and
vjfridge
and removed request for
a team
August 13, 2026 20:39
sameerank
approved these changes
Aug 13, 2026
sameerank
left a comment
Contributor
There was a problem hiding this comment.
Agreed with adding more test coverage 🙌
sameerank
merged commit Aug 13, 2026
9ee5444
into
sameerank/FFL-2835/configuration-from-string
3 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
PR #344 adds production browser entry points and a React Native package smoke test, but the existing browser package check stops after TypeScript and Vite compilation. A package can build successfully while failing when its production output is loaded in a real browser, especially around package exports, initialization order, runtime globals, and capability-specific entry points.
This PR is stacked on #344 to close that runtime coverage gap before those browser APIs merge.
Changes
/precomputedbrowser entry points from packed core/browser tarballsTextEncoder,TextDecoder, andBigIntunavailableconsole.erroroutputDecisions
sameerank/FFL-2835/configuration-from-stringbecause it directly tests the APIs introduced by [FFL-2835] Parse flags configuration wire format #344/precomputedexcludes Protobuf-ES; this browser smoke complements it by proving the entry point executes correctlyValidation
yarn buildyarn lintyarn format:checkyarn testyarn test:browser-install(3 Playwright tests passed)