[chore] update configgrpc references to use configoptional #5280
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackgopack4
force-pushed
the
jackgopack4/update-configgrpc-refs-configoptional
branch
from
f17510d to
1ad5553
Compare
jackgopack4
requested review from
IbraheemA,
ankitpatel96,
billmeyer,
dineshg13,
jade-guiton-dd,
liustanley,
mackjmr,
mx-psi and
songy23
as code owners
jackgopack4
force-pushed
the
jackgopack4/update-configgrpc-refs-configoptional
branch
from
e6f89db to
ae957a6
Compare
… use configoptional for Keepalive, Auth, and ServerConfig.TLS
jackgopack4
force-pushed
the
jackgopack4/update-configgrpc-refs-configoptional
branch
from
ae957a6 to
2a5666b
Compare
jackgopack4
removed request for
IbraheemA,
ankitpatel96,
billmeyer,
dineshg13,
jade-guiton-dd,
liustanley and
mackjmr
Author
|
@crobert-1 @jmacd @dmitryax @tigrannajaryan @JaredTan95 as codeowners of affected components can you review/approve this PR so I can merge into PR branch for open-telemetry#41194? Thanks |
dmitryax
approved these changes
Jul 8, 2025
|
Thanks @jackgopack4 |
Author
|
apologies, had the wrong version of configoptional in gomods |
mx-psi
added a commit
to open-telemetry/opentelemetry-collector-contrib
that referenced
this pull request
Jul 9, 2025
Signed-off-by: jackgopack4 <john.peterson@datadoghq.com> This PR updates the opentelemetry-collector dependency to the latest release. Pushed manually due to GH Actions workflow failure/issues today EDIT: needs DataDog#5280 merged in to update configgrpc references, leaving as draft until codeowners for affected components approve that PR for merge --------- Signed-off-by: jackgopack4 <john.peterson@datadoghq.com> Co-authored-by: Pablo Baeyens <pablo.baeyens@datadoghq.com> Co-authored-by: Pablo Baeyens <pbaeyens31+github@gmail.com>
Dylan-M
pushed a commit
to Dylan-M/opentelemetry-collector-contrib
that referenced
this pull request
Aug 5, 2025
Signed-off-by: jackgopack4 <john.peterson@datadoghq.com> This PR updates the opentelemetry-collector dependency to the latest release. Pushed manually due to GH Actions workflow failure/issues today EDIT: needs DataDog#5280 merged in to update configgrpc references, leaving as draft until codeowners for affected components approve that PR for merge --------- Signed-off-by: jackgopack4 <john.peterson@datadoghq.com> Co-authored-by: Pablo Baeyens <pablo.baeyens@datadoghq.com> Co-authored-by: Pablo Baeyens <pbaeyens31+github@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
update configgrpc references to configoptional
Link to tracking issue
required for open-telemetry/opentelemetry-collector#13252
NEEDS TO BE MERGED INTO open-telemetry#41194
Testing
CI tests
Documentation
none, chore