Skip to content

feat(injector/typed): Enhance type checking with additional generic type test cases#634

Merged
kakkoyun merged 1 commit into
mainfrom
improve-split-package-and-name
Jun 6, 2025
Merged

feat(injector/typed): Enhance type checking with additional generic type test cases#634
kakkoyun merged 1 commit into
mainfrom
improve-split-package-and-name

Conversation

@kakkoyun
Copy link
Copy Markdown
Member

Comprehensive tests have been added to validate these changes, ensuring that the type checker functions correctly across a wide range of generic type scenarios.

Signed-off-by: Kemal Akkoyun kemal.akkoyun@datadoghq.com

@github-actions github-actions Bot added the conventional-commit/feat Feature work label May 27, 2025
@kakkoyun kakkoyun force-pushed the improve-split-package-and-name branch from 762d9cb to cce988a Compare May 27, 2025 13:20
@kakkoyun kakkoyun force-pushed the 04-15-feat_injector_add_argumentthatimplements_method_for_argument_interface_matching branch from 4c0282c to 2be634a Compare May 27, 2025 13:20
@kakkoyun kakkoyun force-pushed the improve-split-package-and-name branch from cce988a to c925737 Compare June 5, 2025 11:00
@kakkoyun kakkoyun force-pushed the 04-15-feat_injector_add_argumentthatimplements_method_for_argument_interface_matching branch from 2be634a to 8ed9ed7 Compare June 5, 2025 11:00
@kakkoyun kakkoyun force-pushed the improve-split-package-and-name branch from c925737 to 60e17fb Compare June 5, 2025 12:41
@kakkoyun kakkoyun force-pushed the 04-15-feat_injector_add_argumentthatimplements_method_for_argument_interface_matching branch 2 times, most recently from 24682c3 to d7599d0 Compare June 5, 2025 14:25
@kakkoyun kakkoyun force-pushed the improve-split-package-and-name branch from 60e17fb to 34fb7e6 Compare June 5, 2025 14:25
@kakkoyun kakkoyun force-pushed the 04-15-feat_injector_add_argumentthatimplements_method_for_argument_interface_matching branch from d7599d0 to cb660b2 Compare June 5, 2025 16:27
@kakkoyun kakkoyun force-pushed the improve-split-package-and-name branch 2 times, most recently from 286edf2 to 31d9f71 Compare June 5, 2025 17:30
@kakkoyun kakkoyun force-pushed the 04-15-feat_injector_add_argumentthatimplements_method_for_argument_interface_matching branch from cb660b2 to 260ef98 Compare June 5, 2025 17:30
@kakkoyun kakkoyun force-pushed the improve-split-package-and-name branch from 31d9f71 to 04fa7c5 Compare June 5, 2025 19:46
@kakkoyun kakkoyun force-pushed the 04-15-feat_injector_add_argumentthatimplements_method_for_argument_interface_matching branch 2 times, most recently from 036a718 to b1fe0c5 Compare June 6, 2025 06:12
@kakkoyun kakkoyun force-pushed the improve-split-package-and-name branch from 04fa7c5 to ed433b7 Compare June 6, 2025 06:12
Base automatically changed from 04-15-feat_injector_add_argumentthatimplements_method_for_argument_interface_matching to main June 6, 2025 07:02
…ype test cases

Comprehensive tests have been added to validate these changes, ensuring that the type checker functions correctly across a wide range of generic type scenarios.

Signed-off-by: Kemal Akkoyun <kemal.akkoyun@datadoghq.com>
@kakkoyun kakkoyun force-pushed the improve-split-package-and-name branch from ed433b7 to 3533698 Compare June 6, 2025 10:57
@kakkoyun kakkoyun enabled auto-merge June 6, 2025 10:58
@kakkoyun kakkoyun added this pull request to the merge queue Jun 6, 2025
Merged via the queue into main with commit d425974 Jun 6, 2025
48 of 54 checks passed
@kakkoyun kakkoyun deleted the improve-split-package-and-name branch June 6, 2025 11:39
@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 6, 2025

Codecov Report

Attention: Patch coverage is 69.23077% with 4 lines in your changes missing coverage. Please review.

Project coverage is 68.36%. Comparing base (8157bfb) to head (3533698).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
internal/injector/typed/typecheck.go 69.23% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #634      +/-   ##
==========================================
+ Coverage   66.95%   68.36%   +1.41%     
==========================================
  Files         113      113              
  Lines        7904     7916      +12     
==========================================
+ Hits         5292     5412     +120     
+ Misses       2094     1964     -130     
- Partials      518      540      +22     
Components Coverage Δ
Generators 80.24% <ø> (ø)
Instruments ∅ <ø> (∅)
Go Driver 76.51% <ø> (ø)
Toolexec Driver 70.83% <ø> (ø)
Aspects 74.32% <ø> (ø)
Injector 74.87% <69.23%> (-0.03%) ⬇️
Job Server 69.23% <ø> (+3.31%) ⬆️
Other 68.36% <69.23%> (+1.41%) ⬆️
Files with missing lines Coverage Δ
internal/injector/typed/typecheck.go 65.38% <69.23%> (+0.23%) ⬆️

... and 4 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants