Skip to content

Conversation

@kakkoyun
Copy link
Member

@kakkoyun kakkoyun commented Sep 3, 2025

  • Add new 'orchestrion lint' command
  • Use multichecker framework to run static analysis checks
  • Include custom help formatting to maintain Orchestrion CLI consistency
  • Add go-errorlint as the first linter
  • Enable comparison and asserts checks by default for error handling validation

Needs polyfloyd/go-errorlint#107 before merging.

Signed-off-by: Kemal Akkoyun [email protected]

@github-actions github-actions bot added the conventional-commit/feat Feature work label Sep 3, 2025
kakkoyun and others added 4 commits September 11, 2025 13:25
- Add new 'orchestrion lint' command
- Use multichecker framework to run static analysis checks
- Include custom help formatting to maintain Orchestrion CLI consistency
- Add go-errorlint as the first linter
- Enable comparison and asserts checks by default for error handling validation

Signed-off-by: Kemal Akkoyun <[email protected]>
Signed-off-by: Kemal Akkoyun <[email protected]>
Signed-off-by: Kemal Akkoyun <[email protected]>
@kakkoyun kakkoyun marked this pull request as ready for review September 11, 2025 11:49
@kakkoyun kakkoyun requested a review from a team as a code owner September 11, 2025 11:49
@kakkoyun kakkoyun enabled auto-merge September 11, 2025 15:23
@kakkoyun kakkoyun added this pull request to the merge queue Sep 11, 2025
@kakkoyun kakkoyun removed this pull request from the merge queue due to a manual request Sep 11, 2025
@kakkoyun kakkoyun enabled auto-merge September 11, 2025 15:30
Signed-off-by: Kemal Akkoyun <[email protected]>
@kakkoyun kakkoyun added this pull request to the merge queue Sep 11, 2025
Merged via the queue into main with commit 2a1c347 Sep 11, 2025
57 checks passed
@kakkoyun kakkoyun deleted the add_lint_subcommand branch September 11, 2025 16:33
@codecov
Copy link

codecov bot commented Sep 11, 2025

Codecov Report

❌ Patch coverage is 0% with 26 lines in your changes missing coverage. Please review.
✅ Project coverage is 67.14%. Comparing base (e061d12) to head (f05506c).
⚠️ Report is 12 commits behind head on main.

Files with missing lines Patch % Lines
internal/cmd/lint.go 0.00% 26 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #693      +/-   ##
==========================================
+ Coverage   65.72%   67.14%   +1.42%     
==========================================
  Files         113      114       +1     
  Lines        7926     7951      +25     
==========================================
+ Hits         5209     5339     +130     
+ Misses       2192     2091     -101     
+ Partials      525      521       -4     
Components Coverage Δ
Generators 80.24% <ø> (ø)
Instruments ∅ <ø> (∅)
Go Driver 76.51% <ø> (+0.69%) ⬆️
Toolexec Driver 70.85% <100.00%> (+3.32%) ⬆️
Aspects 74.30% <100.00%> (+2.39%) ⬆️
Injector 74.85% <100.00%> (+2.06%) ⬆️
Job Server 66.99% <ø> (+1.07%) ⬆️
Other 67.14% <16.12%> (+1.42%) ⬆️
Files with missing lines Coverage Δ
main.go 27.27% <ø> (+1.43%) ⬆️
internal/cmd/lint.go 0.00% <0.00%> (ø)

... and 28 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants