chore(python): use Python 3.12 for all scenarios - #131
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
taegyunkim
force-pushed
the
bump-default-python-3.12
branch
from
August 10, 2026 20:19
8c7348d to
fc75858
Compare
taegyunkim
changed the title
taegyunkim
marked this pull request as draft
August 10, 2026 20:19
taegyunkim
force-pushed
the
bump-default-python-3.12
branch
from
August 10, 2026 20:37
0559b8a to
001c6ac
Compare
taegyunkim
force-pushed
the
bump-default-python-3.12
branch
from
August 10, 2026 20:44
001c6ac to
fdc7f35
Compare
Contributor
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. You're on a roll. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
taegyunkim
marked this pull request as ready for review
August 10, 2026 21:10
KowalskiThomas
approved these changes
Aug 11, 2026
KowalskiThomas
left a comment
KowalskiThomas
left a comment
Contributor
There was a problem hiding this comment.
Sorry, meant to approve in my previous review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Standardizes the Python correctness suite on the existing
prof-python-3.12base image and aligns versioned scenario names with the runtime they exercise.prof-python-3.12._3.11scenario directories, Docker copy paths, test names, documentation, and test fixtures to_3.12.python_basic_idle_3.10scenario and retains its rate-scaled counterpart aspython_basic_idle_3.12.Using one modern baseline avoids splitting comparable profiler checks across aging Python runtimes and ensures newly added scenarios exercise the same baseline by default.
Python 3.12 expectation updates
Python 3.12 changes a few observed profile details:
sleepleaf while preserving the existing thread and duration assertions.Hub.run;loop.run.Greenlet-Nassertions remain intact so per-greenlet attribution stays covered.empty_method. Calling and returning from the no-op consumes some CPU, and Python 3.12 runs measured between 3% and 8%. The assertion still rejects substantial blame attribution to the no-op.Testing
./scripts/lintgo test -run 'TestSchemaValidation|TestDocker' ./...scenarios/python_*/Dockerfilefiles selectprof-python-3.12._3.10or_3.11.git diff --checkThe full Docker scenario matrix will run in CI.