fix(python): update profile expectations - #182
Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit intoAug 14, 2026
Merged
Conversation
taegyunkim
marked this pull request as ready for review
August 13, 2026 14:30
taegyunkim
force-pushed
the
taegyunkim/fix-python-profile-expectations
branch
3 times, most recently
from
August 13, 2026 15:01
eb208da to
1f8f9e1
Compare
taegyunkim
commented
Aug 13, 2026
taegyunkim
left a comment
Contributor
Author
There was a problem hiding this comment.
@KowalskiThomas Just turned off code origins and remote config which simplified things a bit
KowalskiThomas
approved these changes
Aug 14, 2026
KowalskiThomas
left a comment
Contributor
There was a problem hiding this comment.
Nice find with the other threads -- note sure why we had to disable CO for Spans for that to work (RC makes sense, CO for Spans less so), but in any case LGTM.
Contributor
Author
|
/code blockers |
|
View all feedbacks in Devflow UI.
Checking merge blockers for #182...
Detected 1 merge blocker(s) to address: 🔴 Blocking |
taegyunkim
force-pushed
the
taegyunkim/fix-python-profile-expectations
branch
from
August 14, 2026 14:15
1f8f9e1 to
ad45b3b
Compare
gh-worker-dd-mergequeue-cf854d
Bot
deleted the
taegyunkim/fix-python-profile-expectations
branch
August 14, 2026 14:42
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
time.sleepand gevent framesFixes the failures from https://github.com/DataDog/prof-correctness/actions/runs/31654920913.
Why
These scenarios install unpinned dependencies. Run 31496036887 passed on the same prof-correctness commit shortly before dd-trace-py v4.13.0 was released, while the next scheduled runs pulled the new release and exposed two issues.
<module>.<function>. The observed stacks therefore changed fromsleeptotime.sleepand fromloop.runtogevent.libev.corecext.loop.run; the workload and expected durations did not change.SignalUploaderand the remote-config poller can appear as long-livedDummy-1threads. Greenlet's two branches consequently varied from 29-33% when a background thread was present to 48-49% when it was not. There is no single correct percentage for that unstable denominator.The Python base image already disables tracing because these scenarios test the profiler. This change also disables Code Origin and remote configuration, removing their unrelated background threads. The original duration-independent percentage targets and error margins remain unchanged.
With dd-trace-py v4.13.0 and both background services disabled locally, greenlet's branches measured 47% and 49% against the original 50% ± 15% expectations. uWSGI measured 47% for the requester and 45% for the worker against the original 50% ± 20% and 42% ± 10% expectations.
The other scenarios named in the Slack messages passed. They were only grouped into the same failed matrix shards.
Testing
go test ./analysis/... ./cmd/list-scenarios/... ./cmd/prof-analyze/...go test -run '^TestSchemaValidation$' -count=1