Sort on-call pages by recent first by default - #710
Merged
platinummonkey merged 1 commit intoAug 7, 2026
Conversation
|
Bits Code status: ✅ Done Comment @DataDog to request changes |
|
I can only run on private repositories. |
jack-edmonds-dd
approved these changes
Aug 7, 2026
platinummonkey
deleted the
dd/fix/on-call-pages-newest-first-202608071555
branch
August 7, 2026 17:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Makes
pup on-call pages listrequest newest on-call pages first by default by sendingsort=-created_atto the unstable pages endpoint, and exposes--sortforcreated_atand-created_at.Motivation
Teams with more than 1000 historical pages could not reach current pages because the command requested only oldest-first results from a capped endpoint. Defaulting to newest-first keeps current pages reachable while the stable paginated and time-filtered backend endpoint is unavailable.
Additional Notes
This keeps the existing unstable endpoint and does not add
--fromor--to; pagination remains limited by the backend.Changes
--sorttoon-call pages listwith default-created_at./api/unstable/on-call/pages.Testing
cargo +stable fmt --checkgit diff --checkcargo +stable test on_call_pages -- --test-threads=1, but cargo could not fetch the pinneddatadog-api-client-rustgit dependency because the sandbox allowlist returned HTTP 403.CARGO_NET_GIT_FETCH_WITH_CLI=true cargo +stable test on_call_pages -- --test-threads=1; it hit the same allowlist HTTP 403.Checklist
Related Issues
Closes #709
PR by Bits - View session in Datadog
Comment @DataDog to request changes