Auto-fallback log Flex storage - #727
Open
platinummonkey wants to merge 3 commits into
Open
Conversation
Co-authored-by: platinummonkey <cody.lee@datadoghq.com>
|
I can only run on private repositories. |
This comment has been minimized.
This comment has been minimized.
…-fallback-20260813 Co-authored-by: platinummonkey <cody.lee@datadoghq.com> # Conflicts: # src/commands/logs.rs # src/test_commands.rs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds automatic log storage selection for
pup logs searchandpup logs aggregate: omitted--storagenow tries Flex first when safe and falls back to indexed logs when Flex is unavailable.Motivation
PR #716 made Flex the hard default for log search and aggregate commands, which caused a negative customer impact for accounts that were not enabled for Flex. This keeps the Flex-first behavior for eligible accounts while preserving working defaults for customers that cannot use Flex yet.
Additional Notes
Changes:
flexdefault so omitted storage is distinguishable from explicit--storage flex.autostorage handling that tries Flex only when no explicit storage or index is supplied.--storage flexfailures without fallback.maininto the PR branch and resolved conflicts with the new logs patterns command tests.Testing
RUSTUP_TOOLCHAIN=stable-x86_64-unknown-linux-gnu cargo fmt --checkgit diff --checksrc/commands/logs.rsandsrc/test_commands.rswhile keeping both the auto-storage tests and the new logs patterns tests frommain.RUSTUP_TOOLCHAIN=stable-x86_64-unknown-linux-gnu cargo test logs --lib -- --nocapture, but it was blocked because Cargo could not fetch the pinneddatadog-api-client-rustgit dependency in this sandbox (GitHub returned 403 for the dependency fetch).cargo clippy --lib -- -D warningswas also blocked by the same dependency fetch issue.Checklist
Related Issues
Follow-up to PR #716.
PR by Bits - View session in Datadog
Comment @DataDog to request changes