Skip to content

fix(version): correct ldflags variable names for build metadata #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
platinummonkey merged 1 commit into from
Feb 17, 2026
Merged

fix(version): correct ldflags variable names for build metadata #74

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions .goreleaser.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,8 @@ builds:
ldflags:
- -s -w
- -X github.com/DataDog/pup/internal/version.Version={{.Version}}
- -X github.com/DataDog/pup/internal/version.Commit={{.Commit}}
- -X github.com/DataDog/pup/internal/version.Date={{.Date}}
- -X github.com/DataDog/pup/internal/version.BuiltBy=goreleaser
- -X github.com/DataDog/pup/internal/version.GitCommit={{.Commit}}
- -X github.com/DataDog/pup/internal/version.BuildDate={{.Date}}

archives:
- id: pup
Expand Down
5 changes: 2 additions & 3 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,8 @@ DATE := $(shell date -u +"%Y-%m-%dT%H:%M:%SZ")
# Build flags
LDFLAGS := -s -w \
-X github.com/DataDog/pup/internal/version.Version=$(VERSION) \
-X github.com/DataDog/pup/internal/version.Commit=$(COMMIT) \
-X github.com/DataDog/pup/internal/version.Date=$(DATE) \
-X github.com/DataDog/pup/internal/version.BuiltBy=makefile
-X github.com/DataDog/pup/internal/version.GitCommit=$(COMMIT) \
-X github.com/DataDog/pup/internal/version.BuildDate=$(DATE)

# Go build flags
GO_BUILD_FLAGS := -trimpath -ldflags "$(LDFLAGS)"
Expand Down