Skip to content

RUM-9561 Update view schema to add accessibility attributes - #270

Merged
dd-mergequeue[bot] merged 1 commit into
masterfrom
bplasovska/RUM-9561/accessibility-attributes
Jul 17, 2025
Merged

RUM-9561 Update view schema to add accessibility attributes#270
dd-mergequeue[bot] merged 1 commit into
masterfrom
bplasovska/RUM-9561/accessibility-attributes

Conversation

@barboraplasovska

@barboraplasovska barboraplasovska commented May 13, 2025

Copy link
Copy Markdown
Contributor

Adds new accessibility parameters to the RUM View schema.

  • text_size - User’s preferred text scale relative to the default system size.
  • screen_reader_enabled - Indicates whether a screen reader is currently active.
  • bold_text_enabled - Indicates whether the system-wide bold text accessibility setting is enabled.
  • reduce_transparency_enabled - Indicates whether the system-wide reduce transparency setting is enabled.
  • reduce_motion_enabled - Indicates whether the system-wide reduce motion setting is enabled.
  • button_shapes_enabled - Indicates whether the system-wide button shapes setting is enabled.
  • invert_colors_enabled - Indicates whether the system-wide color inversion setting is enabled.
  • increase_contrast_enabled - Indicates whether the system-wide increase contrast setting is enabled.
  • assistive_switch_enabled - Indicates whether an alternative input method like Switch Control or Switch Access is currently enabled.
  • assistive_touch_enabled - Indicates whether the system-wide AssistiveTouch feature is currently enabled.
  • is_video_autoplay_enabled - Indicates whether the video autoplay setting is enabled in the system or application.
  • closed_captioning_enabled - Indicates whether closed captioning is enabled for media playback.
  • mono_audio_enabled - Indicates whether the system-wide mono audio setting is enabled.
  • shake_to_undo_enabled - Indicates whether the Shake to Undo feature is enabled.
  • reduced_animations_enabled - Indicates whether the user prefers reduced animations or cross-fade transitions.
  • should_differentiate_without_color - Indicates whether the system should differentiate interface elements without relying solely on color.
  • grayscale_enabled - Indicates whether the device display is currently using grayscale mode.
  • single_app_mode_enabled - Indicates whether the device is currently locked to a single app through Guided Access or Screen Pinning.
  • on_off_switch_labels_enabled - Indicates whether on/off switch labels are enabled in the system settings.
  • speak_screen_enabled - Indicates whether the Speak Screen feature is enabled.
  • speak_selection_enabled - Indicates whether the text-to-speech selection feature is enabled.

@barboraplasovska barboraplasovska self-assigned this May 13, 2025
@barboraplasovska
barboraplasovska requested review from a team as code owners May 13, 2025 14:24
hemeryar
hemeryar previously approved these changes May 14, 2025

@hemeryar hemeryar left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@barboraplasovska
barboraplasovska marked this pull request as draft May 27, 2025 09:05
@barboraplasovska
barboraplasovska force-pushed the bplasovska/RUM-9561/accessibility-attributes branch from 7519d83 to 084a59c Compare July 15, 2025 12:21
@barboraplasovska
barboraplasovska marked this pull request as ready for review July 15, 2025 12:31
@barboraplasovska
barboraplasovska force-pushed the bplasovska/RUM-9561/accessibility-attributes branch from 084a59c to 6592651 Compare July 15, 2025 12:32
Manu-Tran
Manu-Tran previously approved these changes Jul 15, 2025
Comment on lines +1767 to +1770
/**
* Indicates whether the system-wide reduce motion setting is enabled.
*/
readonly reduce_motion_enabled?: boolean;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❓ question: ‏ What is the difference between reduce_motion_enabled and reduced_animations_enabled? In the browser, we expect animations to be reduced or removed when we detect the prefers-reduced-motion flag.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reduce_motion_enabled indicates whether the Reduce Motion setting is in an enabled state. (doc)
reduce_animations_enabled indicates whether the Reduce Motion and the Prefer Cross-Fade Transitions settings are in an enabled state. (doc)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that reduce_motion is only available on iOS, while Android and the web focus more on animations. Should we consolidate this into a single value?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the suggestion !
Just to give some context, we aligned on these two attributes a while ago through multiple RFCs, and they’re already being sent as custom attributes behind a feature flag. The implementation has been released in the iOS SDK and is currently being dogfooded in the iOS mobile app, where it's also used to populate a dashboard.
At this stage, the work is already quite far along, so I don't think it would make sense to revisit the structure unless there's a critical issue.

Comment thread lib/cjs/generated/rum.d.ts
Comment thread lib/esm/generated/rum.d.ts Outdated
@barboraplasovska
barboraplasovska force-pushed the bplasovska/RUM-9561/accessibility-attributes branch from 6592651 to 9378e83 Compare July 16, 2025 09:18
@barboraplasovska

Copy link
Copy Markdown
Contributor Author

/merge

@dd-devflow-routing-codex

dd-devflow-routing-codex Bot commented Jul 17, 2025

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2025-07-17 14:12:00 UTC ℹ️ Start processing command /merge


2025-07-17 14:12:29 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 8m (p90).


2025-07-17 14:22:30 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue
dd-mergequeue Bot merged commit 8415508 into master Jul 17, 2025
10 checks passed
@dd-mergequeue
dd-mergequeue Bot deleted the bplasovska/RUM-9561/accessibility-attributes branch July 17, 2025 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants