-
Notifications
You must be signed in to change notification settings - Fork 7
Add not restored reasons property #307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
rgaignault
wants to merge
1
commit into
master
Choose a base branch
from
romanG/no-restored-reasons
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -901,6 +901,10 @@ export declare type RumViewEvent = CommonProperties & ViewContainerSchema & Stre | |
* Duration in ns to the response start of the document request | ||
*/ | ||
readonly first_byte?: number; | ||
/** | ||
* Reasons why the document was blocked from using the back/forward cache | ||
*/ | ||
not_restored_reasons?: NotRestoredReasonsSchema; | ||
/** | ||
* User custom timings of the view. As timing name is used as facet path, it must contain only letters, digits, or the characters - _ . @ $ | ||
*/ | ||
|
@@ -1755,6 +1759,42 @@ export interface StreamSchema { | |
}; | ||
[k: string]: unknown; | ||
} | ||
/** | ||
* Reasons why the document was blocked from using the back/forward cache | ||
*/ | ||
export interface NotRestoredReasonsSchema { | ||
/** | ||
* Array of NotRestoredReasons objects for child iframes | ||
*/ | ||
readonly children?: NotRestoredReasonsSchema[]; | ||
/** | ||
* ID attribute value of the iframe | ||
*/ | ||
readonly id?: string | null; | ||
/** | ||
* Name attribute value of the iframe | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Question: Same as ID, Why |
||
*/ | ||
readonly name?: string | null; | ||
/** | ||
* Array of reasons why the page was blocked from using bfcache | ||
*/ | ||
readonly reasons?: { | ||
/** | ||
* The reason why the page was blocked | ||
*/ | ||
readonly reason: string; | ||
[k: string]: unknown; | ||
}[] | null; | ||
/** | ||
* Source path of the iframe | ||
*/ | ||
readonly src?: string | null; | ||
/** | ||
* URL of the navigated page or iframe | ||
*/ | ||
readonly url?: string | null; | ||
[k: string]: unknown; | ||
} | ||
/** | ||
* Schema of properties for a technical performance metric | ||
*/ | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,55 @@ | ||
{ | ||
"$schema": "http://json-schema.org/draft-07/schema", | ||
"$id": "rum/_not-restored-reasons-schema.json", | ||
"title": "NotRestoredReasonsSchema", | ||
"type": "object", | ||
"description": "Reasons why the document was blocked from using the back/forward cache", | ||
"properties": { | ||
"children": { | ||
"type": "array", | ||
"description": "Array of NotRestoredReasons objects for child iframes", | ||
"items": { | ||
"$ref": "#" | ||
}, | ||
"readOnly": true | ||
}, | ||
"id": { | ||
"type": ["string", "null"], | ||
"description": "ID attribute value of the iframe", | ||
"readOnly": true | ||
}, | ||
"name": { | ||
"type": ["string", "null"], | ||
"description": "Name attribute value of the iframe", | ||
"readOnly": true | ||
}, | ||
"reasons": { | ||
"type": ["array", "null"], | ||
"description": "Array of reasons why the page was blocked from using bfcache", | ||
"items": { | ||
"type": "object", | ||
"required": ["reason"], | ||
"properties": { | ||
"reason": { | ||
"type": "string", | ||
"description": "The reason why the page was blocked", | ||
"readOnly": true | ||
} | ||
}, | ||
"readOnly": true | ||
}, | ||
"readOnly": true | ||
}, | ||
"src": { | ||
"type": ["string", "null"], | ||
"description": "Source path of the iframe", | ||
"readOnly": true | ||
}, | ||
"url": { | ||
"type": ["string", "null"], | ||
"description": "URL of the navigated page or iframe", | ||
"readOnly": true | ||
} | ||
}, | ||
"readOnly": true | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question: Why
ID attribute value
and not justID
?