Add response error graphql properties #308
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcaudan
reviewed
Oct 13, 2025
schemas/rum/resource-schema.json
Outdated
| }, | ||
| "code": { | ||
| "type": "string", | ||
| "description": "Error code from GraphQL extensions", |
There was a problem hiding this comment.
💬 suggestion: IMO, mentioning GraphQL extensions can be a bit confusing here because it requires to be aware of this concept of the GraphQL spec, and it could easily be misunderstood with the extension concept we have at SDK level.
I think we could:
- Not mention it at all,
"Error code" - Not mention GraphQL extension,
"Error code (used by some providers)"
There was a problem hiding this comment.
Sounds good ! I would prefer the second one as it is not always present. (to inform customers why it's not there)
bcaudan
reviewed
Oct 14, 2025
bcaudan
previously approved these changes
Oct 14, 2025
satween
approved these changes
Oct 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new properties for the following support for graphql response tracking.
Note : The code property is not native but taken from the extension field and move at the top level. As we would like to query directly :
@resource.[…].errors.code:xxx. It is present in the spec as a field in the extension part, so it could be manually added by the customers but also some libraries such as Apollo directly provide it in the response. (see Documentation)See the spec for more informations about the graphql response format : GraphQL Spec