[PANA-5341] Add constants to make interacting with BrowserChangeRecords easier - #336
Merged
sethfowler-datadog merged 1 commit intoJan 8, 2026
Conversation
sethfowler-datadog
force-pushed
the
seth.fowler/PANA-5341-add-change-record-constants
branch
from
January 7, 2026 18:16
1f8d1cb to
e410800
Compare
mormubis
approved these changes
Jan 8, 2026
sethfowler-datadog
deleted the
seth.fowler/PANA-5341-add-change-record-constants
branch
January 8, 2026 15:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #278 added
BrowserChangeRecord, a new record type that allows us to express mutations in a more compact way. While that PR included a complete definition of the new additions to the JSON schema, I discovered today that there are some additional type and data structure definitions exposed byrum-events-formatthat are defined directly in TypeScript. This PR updates these definitions to includeBrowserChangeRecordand its related types. I've imported these definitions from thebrowser-sdkrepo; as a followup, I'll remove the duplicated definitions from that repo, so that we can standardize on these ones.