馃敡 enable ajv strict mode and fix view schema type declaration - #366
Merged
Conversation
- Add `strict: true` to Ajv options to surface schema issues earlier - Add `allowUnionTypes: true` to relax the strict mode rule disallowing union types, since the schemas use them intentionally - Wrap `ajv.validate()` in a try/catch to report schema-level errors (e.g. unknown keywords) without crashing, since strict mode can throw instead of returning false - Add `"type": "object"` to the `view` property in view-schema.json, which strict mode now requires
BenoitZugmeyer
marked this pull request as ready for review
March 13, 2026 11:48
mormubis
approved these changes
Mar 13, 2026
sethfowler-datadog
approved these changes
Mar 17, 2026
BenoitZugmeyer
added a commit
to DataDog/browser-sdk
that referenced
this pull request
Mar 17, 2026
Running the unit tests is spamming a *lot* of logs, because of ajv printing warnings about a missing type property. This was fixed in DataDog/rum-events-format#366.
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Previously, ajv was logging strict mode issues to the console but
validate.mjswas not returning a non-zero exit code, so CI would pass silently despite schema
problems. This PR makes the script fail properly when schema issues are detected.
Changes
strict: truein Ajv so schema issues throw instead of just loggingallowUnionTypes: trueto allow the union types used intentionallyacross our schemas
ajv.validate()in a try/catch so thrown errors are reported cleanlyand set a non-zero exit code
"type": "object"to theviewproperty in view-schema.json, whichstrict mode requires