Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .gitlab-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ variables:
# Converged Datadog Agent-specific variables, which control how we build the converged Datadog Agent image that we
# publicly publish.
PUBLIC_DSD_VERSION: "7.80.2"
PUBLIC_DD_AGENT_VERSION: "7.80.2-jmx"
PUBLIC_DD_AGENT_VERSION: "7.80.2-full"

# Base images to copy Agent Data Plane into, depending on whether the image is meant for our internal environment or
# public registries.
Expand Down
2 changes: 1 addition & 1 deletion docker/Dockerfile.datadog-agent
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
ARG DD_AGENT_VERSION=7.80.2-jmx
ARG DD_AGENT_VERSION=7.80.2-full
ARG DD_AGENT_IMAGE=registry.datadoghq.com/agent:${DD_AGENT_VERSION}
ARG ADP_IMAGE=saluki-images/agent-data-plane:testing-devel

Expand Down
33 changes: 7 additions & 26 deletions renovate.json5
Original file line number Diff line number Diff line change
Expand Up @@ -50,25 +50,6 @@
// weekly non-major group)
"osvVulnerabilityAlerts": true,

// Paths Renovate skips entirely, before any manager (built-in or custom) extracts from them.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the renovate diff a mistake in this PR?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, this is actually expected. Given we no longer have a separate image tag specified in the correctness tests, we no longer need to override the default ignore paths (which include **/test/** by default).

//
// This overrides the list inherited from `config:recommended` (via `:ignoreModulesAndTests`).
// We reproduce its defaults but drop the broad `**/test/**` entry: that pattern would otherwise
// hide test/correctness/cases/*/config.yaml from the custom Agent-pin manager below, so the
// OTLP baseline image pins would silently keep drifting. The only dependency files under test/
// that built-in managers recognize live in test/antithesis/deploy (a Dockerfile and a
// docker-compose), which we keep ignoring here to preserve current behavior.
"ignorePaths": [
"**/node_modules/**",
"**/bower_components/**",
"**/vendor/**",
"**/examples/**",
"**/__tests__/**",
"**/tests/**",
"**/__fixtures__/**",
"test/antithesis/**"
],

// Package-manager-specific rules.
"packageRules": [
// Use Cargo's semver interpretation for all Cargo dependencies. Cargo
Expand Down Expand Up @@ -111,13 +92,14 @@
// Custom managers for Datadog Agent version pins that Renovate's built-in managers don't see.
//
// The `dockerfile` manager already bumps docker/Dockerfile.datadog-agent (the
// `registry.datadoghq.com/agent` FROM/ARG). But several other pins for the same Agent are
// hand-maintained in files no default manager parses, so they were silently left behind on past
// bumps (see the 7.80.1 -> 7.80.2 update). Manage them here, tied to the same depName
// `registry.datadoghq.com/agent` FROM/ARG). But a couple of other pins for the same Agent are
// hand-maintained in files no default manager parses -- the macOS test Agent version (Makefile)
// and the Windows LTSC base image (.gitlab/windows.yml) -- so they were silently left behind on
// past bumps (see the 7.80.1 -> 7.80.2 update). Manage them here, tied to the same depName
// (`registry.datadoghq.com/agent`) so they bump in lockstep with -- and in the same PR as -- the
// main Agent image.
//
// `currentValue` captures only the numeric version; any image-tag suffix (-full, -ltsc2022, -jmx)
// `currentValue` captures only the numeric version; any image-tag suffix (-ltsc2022, -jmx, -full)
// is matched but left out of the group, so Renovate rewrites just the number and preserves the
// suffix in place. Because the suffixed tags are published together with the bare release, every
// pin tracks the same single Agent version rather than drifting onto separate per-suffix streams.
Expand All @@ -126,13 +108,12 @@
"customType": "regex",
"fileMatch": [
"(^|/)Makefile$",
"^\\.gitlab/windows\\.yml$",
"^test/correctness/cases/.+/config\\.yaml$"
"^\\.gitlab/windows\\.yml$"
],
"matchStrings": [
// Bare version, e.g. `MACOS_TEST_AGENT_VERSION ?= 7.80.2` (Makefile).
"MACOS_TEST_AGENT_VERSION \\?= (?<currentValue>[\\d.]+)",
// Image pins, e.g. `registry.datadoghq.com/agent:7.80.2-full` or `:7.80.2-ltsc2022`.
// Image pin, e.g. `registry.datadoghq.com/agent:7.80.2-ltsc2022` (.gitlab/windows.yml).
// The `-suffix` is matched but not captured, so only the number is rewritten.
"registry\\.datadoghq\\.com/agent:(?<currentValue>[\\d.]+)(?:-[a-z0-9]+)?"
],
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ additional_span_ignore_fields:
- metrics._top_level
- metrics._dd.measured
baseline:
image: registry.datadoghq.com/agent:7.80.2-full
image: saluki-images/datadog-agent:testing-release
# Run DDOT (otel-agent) directly so the image entrypoint does not treat our args as a command to exec.
#entrypoint:
# - /opt/datadog-agent/embedded/bin/otel-agent
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ additional_span_ignore_fields:
- metrics.http.status_code
- meta.error.msg
baseline:
image: registry.datadoghq.com/agent:7.80.2-full
image: saluki-images/datadog-agent:testing-release
files:
- collector.yaml:/etc/datadog-agent/otel-config.yaml
- datadog_agent.yaml:/etc/datadog-agent/datadog.yaml
Expand Down