chore(ci): copy PDB into Windows zip archive

[tobz]

Summary

As stated in the PR title.

Change Type

• Bug fix
• New feature
• Non-functional (chore, refactoring, docs)
• Performance

How did you test this PR?

• Ensured that the resulting ZIP file from the CI build job contained the PDB file.

References

DADP-2

[pr-commenter]

Binary Size Analysis (Agent Data Plane)

Baseline: f939603 · Comparison: 6a9dadc · diff
Analysis Configuration: stripped binaries · Pass/Fail Threshold: +5%
Sizes: 40.28 MiB (baseline) vs 40.28 MiB (comparison)
Size Change: +0 B (+0.00%)

✅ Binary size difference within threshold

Changes by Module

Module	File Size	Symbols
anon.c332a4a573d0a9a1bf7c71b0a1f57672.1.llvm.6451770048914476030	+129 B	1
anon.c332a4a573d0a9a1bf7c71b0a1f57672.1.llvm.1991650048066735225	-129 B	1
anon.c332a4a573d0a9a1bf7c71b0a1f57672.4.llvm.6451770048914476030	+114 B	1
anon.c332a4a573d0a9a1bf7c71b0a1f57672.4.llvm.1991650048066735225	-114 B	1
anon.c332a4a573d0a9a1bf7c71b0a1f57672.3.llvm.6451770048914476030	+108 B	1
anon.c332a4a573d0a9a1bf7c71b0a1f57672.3.llvm.1991650048066735225	-108 B	1
anon.c332a4a573d0a9a1bf7c71b0a1f57672.0.llvm.6451770048914476030	+96 B	1
anon.c332a4a573d0a9a1bf7c71b0a1f57672.0.llvm.1991650048066735225	-96 B	1
anon.c332a4a573d0a9a1bf7c71b0a1f57672.2.llvm.6451770048914476030	+94 B	1
anon.c332a4a573d0a9a1bf7c71b0a1f57672.2.llvm.1991650048066735225	-94 B	1

Detailed Symbol Changes

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  [NEW]    +129  [NEW]     +40    anon.c332a4a573d0a9a1bf7c71b0a1f57672.1.llvm.6451770048914476030
  [NEW]    +114  [NEW]     +25    anon.c332a4a573d0a9a1bf7c71b0a1f57672.4.llvm.6451770048914476030
  [NEW]    +108  [NEW]     +19    anon.c332a4a573d0a9a1bf7c71b0a1f57672.3.llvm.6451770048914476030
  [NEW]     +96  [NEW]      +7    anon.c332a4a573d0a9a1bf7c71b0a1f57672.0.llvm.6451770048914476030
  [NEW]     +94  [NEW]      +5    anon.c332a4a573d0a9a1bf7c71b0a1f57672.2.llvm.6451770048914476030
  [DEL]     -94  [DEL]      -5    anon.c332a4a573d0a9a1bf7c71b0a1f57672.2.llvm.1991650048066735225
  [DEL]     -96  [DEL]      -7    anon.c332a4a573d0a9a1bf7c71b0a1f57672.0.llvm.1991650048066735225
  [DEL]    -108  [DEL]     -19    anon.c332a4a573d0a9a1bf7c71b0a1f57672.3.llvm.1991650048066735225
  [DEL]    -114  [DEL]     -25    anon.c332a4a573d0a9a1bf7c71b0a1f57672.4.llvm.1991650048066735225
  [DEL]    -129  [DEL]     -40    anon.c332a4a573d0a9a1bf7c71b0a1f57672.1.llvm.1991650048066735225
  [ = ]       0  [ = ]       0    TOTAL

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: bc42e17544

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

[pr-commenter]

Regression Detector (Agent Data Plane)

Run ID: 0f51e3b8-61a9-45be-985e-82ea0e711920
Baseline: f939603d · Comparison: 6a9dadca · diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment (35)

Experiments configured erratic: true are tagged (ignored) and skipped when determining which experiments regressed or improved. Experiments which are detected as erratic at runtime are tagged (erratic) to flag that the run's sample dispersion was high, but their regression / improvement signal still counts.

experiment	goal	Δ mean %	links
otlp_ingest_traces_5mb_cpu (erratic)	cpu	⚪ +2.51	metrics profiles logs
otlp_ingest_logs_5mb_memory (ignored)	memory	⚪ +2.11	metrics profiles logs
dsd_uds_500mb_3k_contexts_throughput	throughput	⚪ -2.04	metrics profiles logs
otlp_ingest_traces_ottl_transform_5mb_cpu (erratic)	cpu	⚪ +1.37	metrics profiles logs
dsd_uds_500mb_3k_contexts_cpu (erratic)	cpu	⚪ +0.94	metrics profiles logs
otlp_ingest_traces_ottl_filtering_5mb_cpu (erratic)	cpu	⚪ +0.91	metrics profiles logs
otlp_ingest_metrics_5mb_cpu (erratic)	cpu	⚪ +0.81	metrics profiles logs
otlp_ingest_logs_5mb_cpu (ignored)	cpu	⚪ +0.74	metrics profiles logs
dsd_uds_100mb_3k_contexts_cpu (erratic)	cpu	⚪ +0.63	metrics profiles logs
dsd_uds_10mb_3k_contexts_memory	memory	⚪ +0.55	metrics profiles logs
quality_gates_rss_dsd_heavy	memory	⚪ +0.38	metrics profiles logs
dsd_uds_500mb_3k_contexts_memory	memory	⚪ +0.29	metrics profiles logs
quality_gates_rss_idle	memory	⚪ +0.29	metrics profiles logs
quality_gates_rss_dsd_medium	memory	⚪ +0.20	metrics profiles logs
otlp_ingest_traces_ottl_filtering_5mb_throughput	throughput	⚪ -0.16	metrics profiles logs
otlp_ingest_traces_5mb_memory	memory	⚪ +0.16	metrics profiles logs
dsd_uds_512kb_3k_contexts_memory	memory	⚪ +0.10	metrics profiles logs
quality_gates_rss_dsd_ultraheavy	memory	⚪ +0.04	metrics profiles logs
otlp_ingest_traces_ottl_filtering_5mb_memory	memory	⚪ +0.04	metrics profiles logs
dsd_uds_10mb_3k_contexts_throughput	throughput	⚪ -0.03	metrics profiles logs
otlp_ingest_traces_5mb_throughput	throughput	⚪ -0.02	metrics profiles logs
otlp_ingest_metrics_5mb_throughput	throughput	⚪ -0.02	metrics profiles logs
dsd_uds_512kb_3k_contexts_throughput	throughput	⚪ -0.01	metrics profiles logs
dsd_uds_1mb_3k_contexts_throughput	throughput	⚪ -0.00	metrics profiles logs
otlp_ingest_logs_5mb_throughput (ignored)	throughput	⚪ +0.00	metrics profiles logs
otlp_ingest_traces_ottl_transform_5mb_memory	memory	⚪ -0.00	metrics profiles logs
dsd_uds_100mb_3k_contexts_throughput	throughput	⚪ +0.02	metrics profiles logs
otlp_ingest_traces_ottl_transform_5mb_throughput	throughput	⚪ +0.16	metrics profiles logs
dsd_uds_1mb_3k_contexts_memory	memory	⚪ -0.19	metrics profiles logs
dsd_uds_100mb_3k_contexts_memory	memory	⚪ -0.27	metrics profiles logs
quality_gates_rss_dsd_low	memory	⚪ -0.64	metrics profiles logs
otlp_ingest_metrics_5mb_memory	memory	⚪ -0.83	metrics profiles logs
dsd_uds_10mb_3k_contexts_cpu (erratic)	cpu	⚪ -2.94	metrics profiles logs
dsd_uds_1mb_3k_contexts_cpu (erratic)	cpu	⚪ -3.87	metrics profiles logs
dsd_uds_512kb_3k_contexts_cpu (erratic)	cpu	🟢 -14.54	metrics profiles logs

Bounds Checks: ✅ Passed (5)

experiment	check	replicates	observed	links
quality_gates_rss_dsd_heavy	memory_usage	10/10	✅ 132 MiB ≤ 140 MiB	metrics profiles logs
quality_gates_rss_dsd_low	memory_usage	10/10	✅ 42.5 MiB ≤ 50 MiB	metrics profiles logs
quality_gates_rss_dsd_medium	memory_usage	10/10	✅ 64.7 MiB ≤ 75 MiB	metrics profiles logs
quality_gates_rss_dsd_ultraheavy	memory_usage	10/10	✅ 191 MiB ≤ 200 MiB	metrics profiles logs
quality_gates_rss_idle	memory_usage	10/10	✅ 28.2 MiB ≤ 40 MiB	metrics profiles logs

Explanation

A change is flagged as a regression when |Δ mean %| > 5.00% in the regressing direction for its optimization goal AND SMP marks the experiment as a regression (is_regression: true). Improvements use the matching criteria for the improving direction. Experiments configured erratic: true (tagged (ignored)) are skipped outright; experiments detected as erratic at runtime (tagged (erratic)) still count, since that flag describes sample dispersion rather than directional certainty. The Δ mean % cell is colored accordingly: 🟢 = improvement, 🔴 = regression, ⚪ = neutral. Reduction in CPU or memory is an improvement; reduction in ingress throughput is a regression.

[thieman]

Looks good to me. Is your intent for the PDB to end up in the final Agent package? If not we may need to teach Omnibus to get rid of it.

[tobz]

Looks good to me. Is your intent for the PDB to end up in the final Agent package? If not we may need to teach Omnibus to get rid of it.

@thieman Yeah, we definitely want it to make it as far as the Omnibus build so it can be either included as-is or shunted off to a separate debuginfo-style package or whatever.