fix(agent-data-plane): preserve DNS for hostname IPC endpoints (1.2.x backport) - #2080
Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 2 commits intoJul 10, 2026
Conversation
dd-octo-sts
Bot
added
area/io
There was a problem hiding this comment.
Pull request overview
This backport fixes an ADP 1.2.x regression where IPC client startup could unnecessarily depend on system DNS configuration, while still preserving DNS resolution for hostname-based IPC endpoints.
Changes:
- Conditionally disable DNS resolution only for literal-IP IPC endpoints (and rely on connector logic to noop DNS for vsock/unix transports).
- Update the
adp-ipc-no-dnsintegration test config to the currentassertionsschema. - Fix CA-certificate installation gating in
Dockerfile.proxy-dumperand remove the now-unneeded CA-certs install script.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| test/integration/cases/adp-ipc-no-dns/config.yaml | Updates integration test schema keys/fields to match current harness (assertions + type). |
| lib/saluki-io/src/net/client/http/conn.rs | Clarifies the default behavior of DNS resolution in connector docs. |
| lib/datadog-agent/commons/src/ipc/client/mod.rs | Adds endpoint host parsing to decide when to disable DNS; includes unit tests. |
| docker/scripts/agent-data-plane/app/00-install-ca-certs.sh | Removes unused CA-certs installation script. |
| docker/Dockerfile.proxy-dumper | Fixes `RUN ... |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
tobz
approved these changes
Jul 10, 2026
gh-worker-dd-devflow-36fce6
Bot
added
mergequeue-status: queued
mergequeue-status: in_progress
and removed
mergequeue-status: queued
labels
gh-worker-dd-mergequeue-cf854d
Bot
merged commit Jul 10, 2026
2f27ebc
into
jszwedko/backport-2041-1.2.x
94 checks passed
gh-worker-dd-mergequeue-cf854d
Bot
deleted the
andrewq/fix-ipc-endpoint-dns-1.2.x
branch
July 10, 2026 19:36
gh-worker-dd-devflow-36fce6
Bot
added
mergequeue-status: done
and removed
mergequeue-status: in_progress
labels
jszwedko
pushed a commit
that referenced
this pull request
Jul 10, 2026
… backport) (#2080) ## Summary Backports #2060 onto the ADP 1.2.4 backport in #2058. - Keeps DNS enabled for hostname IPC endpoints. - Disables DNS only for literal-IP and vsock endpoints. - Fixes the 1.2.x integration test schema. - Fixes the proxy-dumper CA certificate condition and removes the unused certificate script. ## Validation Unit tests and Panoramic discovery. Co-authored-by: toby.lawrence <toby.lawrence@datadoghq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Backports #2060 onto the ADP 1.2.4 backport in #2058.
Validation
Unit tests and Panoramic discovery.