feat(metrics): add stateful Foldspace transport - #2318
Draft
aqian01 wants to merge 1 commit into
Draft
Conversation
Regression Detector (Agent Data Plane)Optimization Goals:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Motivation
Stateful metric encoding must happen after endpoint routing so each destination owns independent dictionary and stream state. The complete logical batch remains retained until ACK, which allows an unacknowledged batch to be encoded again against confirmed state after a transport failure or reconnect.
A failure after transmission has unknown delivery, so a resent logical batch may be duplicated, but its metric fields and identity are preserved.
Retry behavior
Configuration
serializer_experimental_use_v3_api.stateful_metrics_enabledstateful_metrics_max_inflight_payloads(default:32)Dependency
Depends on DataDog/foldspace#39 and pins Foldspace commit
7a5feff72311a66e8b6ce004f78b578f733a2b8f.Validation
cargo test -p saluki-components common::datadog::stateful_metrics— 6 passedcargo test -p saluki-components encoders::datadog::metrics— 71 passedcargo test -p saluki-components common::datadog::config— 34 passedcargo test -p saluki-io net::util::retry— 34 passedcargo clippy -p saluki-components -p saluki-core -p saluki-io --all-targets -- -D warningscargo +nightly fmt --all -- --checkgit diff --check