You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Add non-gating SMP experiments for the ADP-only metric_tag_value_allowlist feature introduced by #2271.
The experiments run ADP standalone and use one set of Jinja variables to generate both the allow-list configuration and the Lading corpus. This avoids Core Agent noise and prevents the generated rules from drifting away from the metrics, tags, and values sent by Lading.
The matrix measures:
idle memory for zero rules, one rule with 10 values, 500 and 10,000 rules with 10 values each, and one rule with 10,000 values;
CPU at 100 MiB/s for zero rules, an all-allowed broad-prefix rule, 25% remove and replace mismatch paths, 500 and 10,000 matching prefix rules, and a 10,000-rule full-table miss.
These experiments intentionally have no checks: yet. They belong to the on-demand/nightly full suite so we can establish measurements before choosing quality-gate bounds.
This PR is stacked on #2271. The SMP PR baseline is still the merge base with main, so the comparison includes the parent feature implementation.
Validation
make generate-smp-experiments
make check-smp-experiments
Parsed every generated allow-list and verified rule counts, unique values, and non-overlapping same-tag prefixes.
Started ADP locally with the generated 10,000-rule configuration and confirmed the topology became healthy.
Run ID:c080f32d-4887-42d7-85a7-c7a4ad1881fc Baseline:0f47357a · Comparison:2be0a82f · diff
Optimization Goals: ✅ No significant changes detected
Fine details of change detection per experiment (5)
Experiments configured erratic: true are tagged (ignored) and skipped when determining which experiments regressed or improved. Experiments which are detected as erratic at runtime are tagged (erratic) to flag that the run's sample dispersion was high, but their regression / improvement signal still counts.
A change is flagged as a regression when |Δ mean %| > 5.00% in the regressing direction for its optimization goal AND SMP marks the experiment as a regression (is_regression: true). Improvements use the matching criteria for the improving direction. Experiments configured erratic: true (tagged (ignored)) are skipped outright; experiments detected as erratic at runtime (tagged (erratic)) still count, since that flag describes sample dispersion rather than directional certainty. The Δ mean % cell is colored accordingly: 🟢 = improvement, 🔴 = regression, ⚪ = neutral. Reduction in CPU or memory is an improvement; reduction in ingress throughput is a regression. Experiments tagged (no analysis) show ⚠️ n/a: SMP ran them but produced no analysis, usually because a replicate failed and exhausted its retries. Check the SMP report for that experiment's replicate failures.
lukesteensen
changed the title
test(smp): benchmark metric tag value allowlists
chore(ci): benchmark metric tag value allowlists
Aug 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
area/testAll things testing: unit/integration, correctness, SMP regression, etc.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add non-gating SMP experiments for the ADP-only
metric_tag_value_allowlistfeature introduced by #2271.The experiments run ADP standalone and use one set of Jinja variables to generate both the allow-list configuration and the Lading corpus. This avoids Core Agent noise and prevents the generated rules from drifting away from the metrics, tags, and values sent by Lading.
The matrix measures:
These experiments intentionally have no
checks:yet. They belong to the on-demand/nightly full suite so we can establish measurements before choosing quality-gate bounds.This PR is stacked on #2271. The SMP PR baseline is still the merge base with
main, so the comparison includes the parent feature implementation.Validation
make generate-smp-experimentsmake check-smp-experimentsgit diff --checkReferences