fix(ci): use localhost instead of 127.0.0.1 to avoid dual-stack issues in certain SMP experiments - #2327
Conversation
…es in certain SMP experiments
localhost instead of 127.0.0.1 to avoid dual-stack issues in certain SMP experiments
Binary Size Analysis (Agent Data Plane)Baseline: 0dee0a9 · Comparison: ff46a33 · diff ✅ Binary size difference within thresholdChanges by Module
Detailed Symbol Changes |
There was a problem hiding this comment.
More details
The generator destinations now match ADP’s localhost:6317/6318 listener defaults, and every generated OTLP case remains synchronized with the authoritative experiment template. Lading preserves the hostname through connection setup, so resolution can select the address family available to the listener.
🤖 Datadog Autotest · Commit ff46a33 · What is Autotest? · @DataDog review to ask questions · Any feedback? Reach out in #autotest
localhost instead of 127.0.0.1 to avoid dual-stack issues in certain SMP experimentslocalhost instead of 127.0.0.1 to avoid dual-stack issues in certain SMP experiments
Regression Detector (Agent Data Plane)Run ID: Optimization Goals: ✅ No significant changes detectedFine details of change detection per experiment (5)Experiments configured
Bounds Checks: ✅ Passed (5)
ExplanationA change is flagged as a regression when |Δ mean %| > 5.00% in the regressing direction for its optimization goal AND SMP marks the experiment as a regression ( |
Regression Detector (Agent Data Plane, full suite)Run ID: Optimization Goals: ✅ No significant changes detectedFine details of change detection per experiment (43)Experiments configured
Bounds Checks: ✅ Passed (5)
ExplanationA change is flagged as a regression when |Δ mean %| > 5.00% in the regressing direction for its optimization goal AND SMP marks the experiment as a regression ( |
Summary
This PR fixes an issue with the OTLP-specific SMP experiments referencing
127.0.0.1directly when ADP was referencinglocalhost, leading to mismatches in dual-stack environments where one side was expecting IPv4 and the other expecting IPv6.This was a little messed up with some recent refactoring around how the ports are defined and we had added some compensating configuration changes in some tests, but not SMP experiments. Rather than add the same compensating changes (listen on
0.0.0.0instead oflocalhost, basically), we've simply mirrored the use oflocalhoston theladingside, which means that while we may use IPv4 or IPv6... both sides (ADP andlading) always use the same version.Change Type
How did you test this PR?
References
DADP-2