chore(agent-data-plane): drop orphaned build-dependency

[jszwedko]

Summary

agent-data-plane declares a [build-dependencies] entry for chrono but has no build script, so the dependency does nothing. It's a leftover: the crate did have a build.rs until #291 moved build metadata capture into saluki-metadata and deleted it, and the build-dependency was never cleaned up alongside it.

Test plan

• Confirmed no build.rs exists anywhere under bin/, and traced the history — added in [APR-107] chore: massively improve error messages #45, deleted in chore: add new crate, saluki-metadata, for easier cross-crate build metadata access #291
• cargo build --package agent-data-plane succeeds with Cargo.lock unchanged, confirming nothing was resolving through the build-dependency
• make check-unused-deps still passes

[datadog-prod-us1-4]

More details

The removed chrono build-dependency is unreachable because agent-data-plane has no build script. Runtime chrono use remains backed by the normal dependency declaration, and build metadata is independently produced by saluki-metadata.

Was this helpful? React 👍 or 👎

_{Open Bits AI session}

_{🤖 Datadog Autotest · Commit ab81497 · What is Autotest? · @DataDog review to ask questions · Any feedback? Reach out in #autotest}

[pr-commenter]

Binary Size Analysis (Agent Data Plane)

Baseline: d6c6e40 · Comparison: ab81497 · diff
Analysis Configuration: stripped binaries · Pass/Fail Threshold: +5%
Sizes: 41.27 MiB (baseline) vs 41.27 MiB (comparison)
Size Change: +0 B (+0.00%)

✅ Binary size difference within threshold

Changes by Module

Module	File Size	Symbols
anon.dca7d28c8f462601bb81d85101fb8da4.1.llvm.14146324926327217739	+130 B	1
anon.dca7d28c8f462601bb81d85101fb8da4.1.llvm.7435387941640750099	-129 B	1
anon.dca7d28c8f462601bb81d85101fb8da4.4.llvm.14146324926327217739	+114 B	1
anon.dca7d28c8f462601bb81d85101fb8da4.4.llvm.7435387941640750099	-113 B	1
anon.dca7d28c8f462601bb81d85101fb8da4.3.llvm.14146324926327217739	+109 B	1
anon.dca7d28c8f462601bb81d85101fb8da4.3.llvm.7435387941640750099	-108 B	1
anon.dca7d28c8f462601bb81d85101fb8da4.0.llvm.14146324926327217739	+97 B	1
anon.dca7d28c8f462601bb81d85101fb8da4.0.llvm.7435387941640750099	-96 B	1
anon.dca7d28c8f462601bb81d85101fb8da4.2.llvm.14146324926327217739	+95 B	1
anon.dca7d28c8f462601bb81d85101fb8da4.2.llvm.7435387941640750099	-94 B	1
[Unmapped]	-5 B	1

Detailed Symbol Changes

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  [NEW]    +130  [NEW]     +40    anon.dca7d28c8f462601bb81d85101fb8da4.1.llvm.14146324926327217739
  [NEW]    +114  [NEW]     +24    anon.dca7d28c8f462601bb81d85101fb8da4.4.llvm.14146324926327217739
  [NEW]    +109  [NEW]     +19    anon.dca7d28c8f462601bb81d85101fb8da4.3.llvm.14146324926327217739
  [NEW]     +97  [NEW]      +7    anon.dca7d28c8f462601bb81d85101fb8da4.0.llvm.14146324926327217739
  [NEW]     +95  [NEW]      +5    anon.dca7d28c8f462601bb81d85101fb8da4.2.llvm.14146324926327217739
  -9.4%      -5  [ = ]       0    [Unmapped]
  [DEL]     -94  [DEL]      -5    anon.dca7d28c8f462601bb81d85101fb8da4.2.llvm.7435387941640750099
  [DEL]     -96  [DEL]      -7    anon.dca7d28c8f462601bb81d85101fb8da4.0.llvm.7435387941640750099
  [DEL]    -108  [DEL]     -19    anon.dca7d28c8f462601bb81d85101fb8da4.3.llvm.7435387941640750099
  [DEL]    -113  [DEL]     -24    anon.dca7d28c8f462601bb81d85101fb8da4.4.llvm.7435387941640750099
  [DEL]    -129  [DEL]     -40    anon.dca7d28c8f462601bb81d85101fb8da4.1.llvm.7435387941640750099
  [ = ]       0  [ = ]       0    TOTAL

[pr-commenter]

Regression Detector (Agent Data Plane)

Run ID: 44886d8e-825f-4a9d-bc0e-0ed05a724434
Baseline: d6c6e40d · Comparison: ab81497f · diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment (5)

Experiments configured erratic: true are tagged (ignored) and skipped when determining which experiments regressed or improved. Experiments which are detected as erratic at runtime are tagged (erratic) to flag that the run's sample dispersion was high, but their regression / improvement signal still counts.

experiment	goal	Δ mean %	links
quality_gates_rss_dsd_medium	memory	⚪ +0.53	metrics profiles logs
quality_gates_rss_idle	memory	⚪ +0.43	metrics profiles logs
quality_gates_rss_dsd_low	memory	⚪ +0.15	metrics profiles logs
quality_gates_rss_dsd_heavy	memory	⚪ +0.04	metrics profiles logs
quality_gates_rss_dsd_ultraheavy	memory	⚪ -0.04	metrics profiles logs

Bounds Checks: ✅ Passed (5)

experiment	check	replicates	observed	links
quality_gates_rss_dsd_heavy	memory_usage	10/10	✅ 232 MiB ≤ 250 MiB	metrics profiles logs
quality_gates_rss_dsd_low	memory_usage	10/10	✅ 51.3 MiB ≤ 60 MiB	metrics profiles logs
quality_gates_rss_dsd_medium	memory_usage	10/10	✅ 89.9 MiB ≤ 100 MiB	metrics profiles logs
quality_gates_rss_dsd_ultraheavy	memory_usage	10/10	✅ 415 MiB ≤ 420 MiB	metrics profiles logs
quality_gates_rss_idle	memory_usage	10/10	✅ 31.8 MiB ≤ 40 MiB	metrics profiles logs

Explanation

A change is flagged as a regression when |Δ mean %| > 5.00% in the regressing direction for its optimization goal AND SMP marks the experiment as a regression (is_regression: true). Improvements use the matching criteria for the improving direction. Experiments configured erratic: true (tagged (ignored)) are skipped outright; experiments detected as erratic at runtime (tagged (erratic)) still count, since that flag describes sample dispersion rather than directional certainty. The Δ mean % cell is colored accordingly: 🟢 = improvement, 🔴 = regression, ⚪ = neutral. Reduction in CPU or memory is an improvement; reduction in ingress throughput is a regression. Experiments tagged (no analysis) show ⚠️ n/a: SMP ran them but produced no analysis, usually because a replicate failed and exhausted its retries. Check the SMP report for that experiment's replicate failures.