feat(sticker-catalogue): seed more stickers#163
Merged
Conversation
| await catalogue.goto(); | ||
| }); | ||
|
|
||
| test('loads without authentication', async () => { |
Member
There was a problem hiding this comment.
Not sure this should be visible without auth - in my mental model, I think only the "public dashboard" should be
Collaborator
Author
There was a problem hiding this comment.
@scottgerring hmmm, good point. I guess I thought that we might want to show the catalogue to public users.
Member
There was a problem hiding this comment.
probably not the whole thing tho? I think the public dashboard can show some subset of them. I'm leaving the fetch image API public btw
scottgerring
changed the title
scottgerring
approved these changes
Jan 21, 2026
scottgerring
left a comment
scottgerring
left a comment
Member
There was a problem hiding this comment.
Approved pending making catalogue private (for now at least, I think!)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #150
Tests