Skip to content

chore(sticker-catalogue,web-frontend): fix quarkus compose build issue and broken frontend in E2E tests#214

Merged
scottgerring merged 4 commits into
mainfrom
chore/fixquarkus
Feb 18, 2026
Merged

chore(sticker-catalogue,web-frontend): fix quarkus compose build issue and broken frontend in E2E tests#214
scottgerring merged 4 commits into
mainfrom
chore/fixquarkus

Conversation

@scottgerring

@scottgerring scottgerring commented Feb 16, 2026

Copy link
Copy Markdown
Member

Couple of things to get the builds going again. Commits are broken down accordingly.

Update quarkus - which pulls in new testcontainers version that fixes the "broken by the passage of time" docker issue.

Fix UI - some changes I think largely from the print service subtly broke some bits in the UI. To resolve:

  • AuthProvider doesn't load its children until auth state has resolved; previously we could render even if isLoading was true, which would mean we'd have components loading before user data was available. I'd rather just block until we have it, as it makes everything downstream simpler
  • StickerDetail loading - split the single useEffect into two; one to fetch the sticker details (doesn't need user ID), and one to that checks ownership, that is. This reflects the reality of the auth model which allows access to sticker details without auth (e.g. for public page)
  • Remove the now redundant isLoading check

Fix E2E tests - changed the "Sticker Collector" check to match against the role, now that we're not showing Sticker Collector there anymore. I'm not sure if listing the role in the sidebar makes sense, but this aligns the test with behaviour at least.

@scottgerring scottgerring changed the title chore(sticker-catalogue): fix quarkus compose build issue chore(sticker-catalogue,web-frontend): fix quarkus compose build issue and broken frontend in E2E tests Feb 16, 2026
Comment thread e2e/fixtures/post-login-validation.ts Outdated
Comment thread sticker-catalogue/src/main/resources/application.properties
Comment thread sticker-catalogue/src/test/resources/application.properties
@scottgerring scottgerring marked this pull request as ready for review February 16, 2026 16:19
@scottgerring scottgerring merged commit 2735a91 into main Feb 18, 2026
16 checks passed
@scottgerring scottgerring deleted the chore/fixquarkus branch February 18, 2026 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants