Skip to content

chore: enable js-profiling Document Policy#219

Merged
scottgerring merged 3 commits into
mainfrom
fix/enable-js-profiling
Mar 3, 2026
Merged

chore: enable js-profiling Document Policy#219
scottgerring merged 3 commits into
mainfrom
fix/enable-js-profiling

Conversation

@jeastham1993

Copy link
Copy Markdown
Collaborator

No description provided.

@jeastham1993

Copy link
Copy Markdown
Collaborator Author

@codex could you review this PR please?

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8b68162437

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread shared/infra/aws/lib/network.ts Outdated

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 644706b3f3

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread shared/infra/aws/lib/network.ts Outdated
],
},
corsBehavior: {
accessControlAllowCredentials: true,

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Avoid wildcard origin when allowing credentials

This CORS policy enables accessControlAllowCredentials: true while also allowing origin *, which produces an invalid credentialed CORS response (Access-Control-Allow-Origin: * with credentials) and causes browsers to reject cross-origin requests that include cookies or auth credentials. In environments where the frontend is fetched cross-origin with credentials, those requests will fail despite this policy intending to improve telemetry/correlation behavior.

Useful? React with 👍 / 👎.

@scottgerring scottgerring merged commit 644b51e into main Mar 3, 2026
10 checks passed
@scottgerring scottgerring deleted the fix/enable-js-profiling branch March 3, 2026 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants