chore: add static analysis to award service#22
Conversation
![datadog-datadog-prod-us1[bot]](https://avatars.githubusercontent.com/u/365230?s=60&v=4){kind=small}
|
|
||
| FROM mcr.microsoft.com/dotnet/aspnet:8.0-noble-chiseled AS runtime | ||
| FROM mcr.microsoft.com/dotnet/aspnet:8.0 AS runtime | ||
| RUN apt-get update && apt-get install -y curl && rm -rf /var/lib/apt/lists/* |
There was a problem hiding this comment.
⚪ Code Quality Violation
package curl should have version pinned (...read more)
When using apt-get install, pin the version to avoid unwanted upgrades and undefined behavior.
| // Constructor with fields | ||
| public Sticker(String stickerId, String name, String description, String imageUrl, Integer stickerQuantityRemaining) { | ||
| /** Default constructor for JPA. */ | ||
| public Sticker() {} |
There was a problem hiding this comment.
⚪ Code Quality Violation
Consider adding super() or this() to your constructor (...read more)
In Java, it is suggested to call super() in an extended class. This rule will report a violation if both a call to super() and an overloaded constructor are absent.
| /** Integration test for StickerAwardResource. */ | ||
| @QuarkusTest | ||
| @TestMethodOrder(MethodOrderer.OrderAnnotation.class) | ||
| public class StickerAwardResourceIT { |
There was a problem hiding this comment.
⚪ Code Quality Violation
The name StickerAwardResourceIT does not follow the regex: /^Test.*$|^[A-Z][a-zA-Z0-9]*Test(s|Case)?$/ (...read more)
Enforce a specific naming convention for your classes using custom regexes that allow for customizing the regex per class type, such as, an enum, interface or even abstract classes.
By default, this rule enforces the Pascal case (PascalCase) naming convention.
This rule also verifies the names for test classes if the class includes a @Test annotation.
| } | ||
|
|
||
| // Constructor with fields | ||
| public StickerAssignment() {} |
There was a problem hiding this comment.
⚪ Code Quality Violation
Consider adding super() or this() to your constructor (...read more)
In Java, it is suggested to call super() in an extended class. This rule will report a violation if both a call to super() and an overloaded constructor are absent.
scottgerring
force-pushed
the
chore/award-static-analysis
branch
from
d32a9c6 to
213da8f
Compare
|
@scottgerring is this ready to review? It looks like there is some crossover with the last PR? #21 |
|
@jeastham1993 it is, it's just based off of the same commit the integration tests hang from. once that's merged they'll disappear here and you'll only see the actual change. I'd suggest looking at the PR commit-by-commit anyway, as it's a combo of "add tool" and then "clean up for tool", which is rather noisy looked at in aggregate. |
chore: address lint issues
scottgerring
force-pushed
the
chore/award-static-analysis
branch
from
d64ddbd to
df793e9
Compare
2 participants
Add CheckStyle for linting and Spotless for applying formatting.