chore: fix some missing service name tags#223
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR ensures Datadog tracing for the Lambda-based services uses the intended logical service name by explicitly setting DD_SERVICE from the shared service name, rather than relying on Datadog’s fallback naming (Lambda function name / .NET assembly name).
Changes:
- Add
DD_SERVICEenv var to the user-management instrumented Lambda construct. - Add
DD_SERVICEenv var to the print-service instrumented Lambda construct.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| user-management/infra/aws/lib/constructs/instrumented-function.ts | Sets DD_SERVICE to sharedProps.serviceName for instrumented Lambdas. |
| print-service/infra/aws/lib/constructs/instrumented-function.ts | Sets DD_SERVICE to sharedProps.serviceName for instrumented Lambdas. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
jeastham1993
approved these changes
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
DD_SERVICEenvironment variable to Lambda function constructs (user-management, print-service) so the Datadog tracer uses the correct service name instead of falling back to the AWS function name or .NET assembly name