Skip to content

Conversation

BridgeAR
Copy link
Contributor

Motivation

Refs DataDog/dd-trace-js#6551

This should ideally just be approved and I can merge it as soon as I merge the one in dd-trace-js to keep the diverging time window as small as possible.

Changes

Renamed master -> main branch

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed and the CI green, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@BridgeAR BridgeAR marked this pull request as ready for review September 29, 2025 17:59
@BridgeAR BridgeAR requested a review from a team as a code owner September 29, 2025 17:59
cbeauchesne

This comment was marked as duplicate.

Copy link
Collaborator

@cbeauchesne cbeauchesne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a master to change in file utils/scripts/load-binary.sh line 315

@BridgeAR BridgeAR force-pushed the BridgeAR/2025-09-29-rename-dd-trace-js-main-branch branch from 6a559ea to fa9bd27 Compare September 30, 2025 18:19
@BridgeAR
Copy link
Contributor Author

@cbeauchesne thank you, I had a old checkout. I rebased with latest main and fixed it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants