Skip to content

Conversation

tylfin
Copy link
Member

@tylfin tylfin commented Oct 14, 2025

Motivation

To properly test the APM_MULTICONFIG capability, we have to receive several RC configurations and apply them according to our priority ordering.

Changes

I had to make several changes to get the system-tests RC to perform as expected:

  • Add prev_payloads parameter to build_apm_tracing_command() and send_apm_tracing_command() to track previously sent configs
  • Generate unique UUIDs for each APM_TRACING config path to prevent overwrites when sending multiple configs
  • Update BaseDebuggerTest to maintain prev_payloads state across multiple config sends
  • Remove @missing_feature decorators from test_inproduct_enablement_exception_replay_apm_multiconfig for Java, enabling multi-config testing

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed and the CI green, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

Copy link
Contributor

CODEOWNERS have been resolved as:

tests/debugger/test_debugger_inproduct_enablement.py                    @DataDog/debugger @DataDog/system-tests-core
tests/debugger/utils.py                                                 @DataDog/debugger @DataDog/system-tests-core
utils/_remote_config.py                                                 @DataDog/system-tests-core

@tylfin tylfin force-pushed the tyler.finethy/er-apm-multiconfig branch from ff4d221 to c9b8243 Compare October 14, 2025 17:40
To properly test the APM_MULTICONFIG capability, we have to receive several
RC configurations and apply them according to our priority ordering.

I had to make several changes to get the system-tests RC to perform as expected:

Changes:
- Add prev_payloads parameter to build_apm_tracing_command() and
  send_apm_tracing_command() to track previously sent configs
- Generate unique UUIDs for each APM_TRACING config path to prevent
  overwrites when sending multiple configs
- Update BaseDebuggerTest to maintain prev_payloads state across
  multiple config sends
- Remove @missing_feature decorators from
  test_inproduct_enablement_exception_replay_apm_multiconfig for Java,
  enabling multi-config testing
@tylfin tylfin force-pushed the tyler.finethy/er-apm-multiconfig branch from c9b8243 to 89a9295 Compare October 14, 2025 20:02
@tylfin tylfin changed the title feat(er): enable apm_multiconfig test for Python and Java feat(er): enable apm_multiconfig test for Java Oct 14, 2025
@tylfin tylfin marked this pull request as ready for review October 14, 2025 20:14
@tylfin tylfin requested review from a team as code owners October 14, 2025 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants