Skip to content

Auto-activate php easy wins for apm-lang-platform - #7460

Open
dd-octo-sts[bot] wants to merge 1 commit into
mainfrom
easy-win/apm-lang-platform/php
Open

Auto-activate php easy wins for apm-lang-platform#7460
dd-octo-sts[bot] wants to merge 1 commit into
mainfrom
easy-win/apm-lang-platform/php

Conversation

@dd-octo-sts

@dd-octo-sts dd-octo-sts Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Automated activation of easy-win tests for php owned by apm-lang-platform
View nightly workflow run

  • This PR starts with an automated request-for-changes review to block automatic merge.
  • If you approve this PR, please merge it manually or dismiss that review according to repository rules.
  • If the tests are failing it might be due to a change made since the last nightly system-tests run. You can close the PR, an updated one will be available tomorrow.
  • If you close the PR please also delete the branch

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This automated easy-win activation PR intentionally starts with requested changes to block automatic merge. If you approve this activation, please merge it manually or dismiss this review according to repository rules.

@dd-octo-sts
dd-octo-sts Bot marked this pull request as ready for review August 5, 2026 07:31
@dd-octo-sts
dd-octo-sts Bot requested review from a team as code owners August 5, 2026 07:31
@dd-prapprover-prod-77c48c

dd-prapprover-prod-77c48c Bot commented Aug 5, 2026

Copy link
Copy Markdown

PRApprover will approve and merge this PR, FAQ, #dx-source-code-management

🛠️ PRApproval Status

  • ✅ PR is eligible for auto-approval by rule system-tests-auto-activate-easy-wins - 2026-08-16T06:59:58Z
  • ⬜ CI tests passed
  • ⬜ Approved
  • Manual merge required: this rule does not auto-merge.

➡️ Current phase: CI tests failed. Please fix the failing tests and rerun the workflow, click Workflow Link -> Workflow Starter Link -> Start Workflow

@github-actions

github-actions Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

CODEOWNERS have been resolved as:

manifests/php.yml                                                       @DataDog/apm-php @DataDog/asm-php

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5c0d59765c

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread manifests/php.yml
Comment on lines +1069 to +1070
- declaration: 'missing_feature (CSS v1.2.0: dd-trace-php ships CSS since v1.19.0, but the sidecar stats exporter retains buckets younger than ~20s (buffer_len=2 * bucket_size=10s) and dd_trace_synchronous_flush passes force=false, so short-lived parametric tests never observe a /v0.6/stats request)'
component_version: '>=1.19.0'

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Remove the duplicated skip entries

For PHP versions >=1.19.0, this added condition is byte-for-byte identical to the immediately preceding missing_feature condition, so the manifest still reports the test as skipped rather than activating the easy-win case. The same duplicate block was added for the other trace-stats methods below, which makes the PR a no-op for those tests and can keep accumulating redundant skips on future automated runs; please replace these new entries with the intended activation/removal of the skip condition.

Useful? React with 👍 / 👎.

@dd-prapprover-prod-77c48c dd-prapprover-prod-77c48c Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR has been automatically approved by the DD PR Approver bot.

@dd-octo-sts
dd-octo-sts Bot force-pushed the easy-win/apm-lang-platform/php branch from 5c0d597 to 6a408f3 Compare August 6, 2026 07:31
@dd-prapprover-prod-77c48c
dd-prapprover-prod-77c48c Bot dismissed their stale review August 6, 2026 07:31

new commit added, dismiss all previous approvals

@dd-prapprover-prod-77c48c dd-prapprover-prod-77c48c Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR has been automatically approved by the DD PR Approver bot.

@dd-octo-sts
dd-octo-sts Bot force-pushed the easy-win/apm-lang-platform/php branch from 6a408f3 to fdedc48 Compare August 7, 2026 07:23
@dd-prapprover-prod-77c48c
dd-prapprover-prod-77c48c Bot dismissed their stale review August 7, 2026 07:23

new commit added, dismiss all previous approvals

@dd-prapprover-prod-77c48c dd-prapprover-prod-77c48c Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR has been automatically approved by the DD PR Approver bot.

@dd-octo-sts
dd-octo-sts Bot force-pushed the easy-win/apm-lang-platform/php branch from fdedc48 to f57ee6e Compare August 8, 2026 06:58
@dd-prapprover-prod-77c48c
dd-prapprover-prod-77c48c Bot dismissed their stale review August 8, 2026 06:58

new commit added, dismiss all previous approvals

@dd-prapprover-prod-77c48c dd-prapprover-prod-77c48c Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR has been automatically approved by the DD PR Approver bot.

@dd-octo-sts
dd-octo-sts Bot force-pushed the easy-win/apm-lang-platform/php branch from f57ee6e to 26c2e8b Compare August 9, 2026 07:00
@dd-prapprover-prod-77c48c
dd-prapprover-prod-77c48c Bot dismissed their stale review August 9, 2026 07:00

new commit added, dismiss all previous approvals

@dd-prapprover-prod-77c48c dd-prapprover-prod-77c48c Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR has been automatically approved by the DD PR Approver bot.

@dd-octo-sts
dd-octo-sts Bot force-pushed the easy-win/apm-lang-platform/php branch from 26c2e8b to ed01859 Compare August 10, 2026 07:02
@dd-prapprover-prod-77c48c
dd-prapprover-prod-77c48c Bot dismissed their stale review August 10, 2026 07:02

new commit added, dismiss all previous approvals

@dd-prapprover-prod-77c48c dd-prapprover-prod-77c48c Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR has been automatically approved by the DD PR Approver bot.

@dd-octo-sts
dd-octo-sts Bot force-pushed the easy-win/apm-lang-platform/php branch from ed01859 to 932322f Compare August 11, 2026 07:00
@dd-prapprover-prod-77c48c
dd-prapprover-prod-77c48c Bot dismissed their stale review August 11, 2026 07:00

new commit added, dismiss all previous approvals

@dd-prapprover-prod-77c48c dd-prapprover-prod-77c48c Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR has been automatically approved by the DD PR Approver bot.

@dd-octo-sts
dd-octo-sts Bot force-pushed the easy-win/apm-lang-platform/php branch from 932322f to c2ad359 Compare August 12, 2026 07:11
@dd-prapprover-prod-77c48c
dd-prapprover-prod-77c48c Bot dismissed their stale review August 12, 2026 07:11

new commit added, dismiss all previous approvals

@dd-prapprover-prod-77c48c dd-prapprover-prod-77c48c Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR has been automatically approved by the DD PR Approver bot.

@dd-octo-sts
dd-octo-sts Bot force-pushed the easy-win/apm-lang-platform/php branch from c2ad359 to 90fe071 Compare August 13, 2026 07:20
@dd-prapprover-prod-77c48c
dd-prapprover-prod-77c48c Bot dismissed their stale review August 13, 2026 07:20

new commit added, dismiss all previous approvals

@dd-prapprover-prod-77c48c dd-prapprover-prod-77c48c Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR has been automatically approved by the DD PR Approver bot.

@dd-octo-sts
dd-octo-sts Bot force-pushed the easy-win/apm-lang-platform/php branch from 90fe071 to a6b7e2b Compare August 13, 2026 09:31
@dd-prapprover-prod-77c48c
dd-prapprover-prod-77c48c Bot dismissed their stale review August 13, 2026 09:31

new commit added, dismiss all previous approvals

@dd-prapprover-prod-77c48c dd-prapprover-prod-77c48c Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR has been automatically approved by the DD PR Approver bot.

@dd-octo-sts
dd-octo-sts Bot force-pushed the easy-win/apm-lang-platform/php branch from a6b7e2b to 7443495 Compare August 14, 2026 07:22
@dd-prapprover-prod-77c48c
dd-prapprover-prod-77c48c Bot dismissed their stale review August 14, 2026 07:22

new commit added, dismiss all previous approvals

@dd-prapprover-prod-77c48c dd-prapprover-prod-77c48c Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR has been automatically approved by the DD PR Approver bot.

@dd-octo-sts
dd-octo-sts Bot force-pushed the easy-win/apm-lang-platform/php branch from 7443495 to e168d87 Compare August 15, 2026 06:58
@dd-prapprover-prod-77c48c
dd-prapprover-prod-77c48c Bot dismissed their stale review August 15, 2026 06:58

new commit added, dismiss all previous approvals

@datadog-datadog-prod-us1-2

datadog-datadog-prod-us1-2 Bot commented Aug 15, 2026

Copy link
Copy Markdown

Pipelines  Tests

⚠️ Warnings

🚦 2 Pipeline jobs failed

Testing the test | System Tests (php, dev) / parametric / parametric (1)   View in Datadog   GitHub Actions

See error 2 tests failed due to connection reset errors while accessing the service endpoints for starting spans: 500 Server Error: Internal Server Error for url: http://localhost:4502/trace/otel/start_span and http://localhost:4500/trace/otel/start_span.

🧪 2 Tests failed · 🎯 related to the job error above

🎯 tests.parametric.test_otel_api_interoperability.Test_Otel_API_Interoperability.test_concurrent_traces_in_order[library_env0, parametric-php] from system_tests_suite   View in Datadog
requests.exceptions.HTTPError: 500 Server Error: Internal Server Error for url: http://localhost:4500/trace/otel/start_span

self = <tests.parametric.test_otel_api_interoperability.Test_Otel_API_Interoperability object at 0x7f7ad8b758e0>
test_agent = <utils.docker_fixtures._test_agent.TestAgentAPI object at 0x7f7aa7bb92b0>
test_library = <utils.docker_fixtures._test_clients._test_client_parametric.ParametricTestClientApi object at 0x7f7aa8282e10>

    def test_concurrent_traces_in_order(self, test_agent: TestAgentAPI, test_library: APMLibrary):
        """- Basic concurrent traces and spans"""
        with (
            test_library,
...
🎯 tests.parametric.test_otel_api_interoperability.Test_Otel_API_Interoperability.test_otel_start_after_datadog_span[library_env0, parametric-php] from system_tests_suite   View in Datadog
requests.exceptions.HTTPError: 500 Server Error: Internal Server Error for url: http://localhost:4502/trace/otel/start_span

self = <tests.parametric.test_otel_api_interoperability.Test_Otel_API_Interoperability object at 0x7f1507de9b50>
test_agent = <utils.docker_fixtures._test_agent.TestAgentAPI object at 0x7f14d6ca7b00>
test_library = <utils.docker_fixtures._test_clients._test_client_parametric.ParametricTestClientApi object at 0x7f14d6f296a0>

    def test_otel_start_after_datadog_span(self, test_agent: TestAgentAPI, test_library: APMLibrary):
        """- Start a span using the OTel API while a span created using the Datadog API already exists"""
        with test_library:
            with (
...

Testing the test | all-jobs-are-green   View in Datadog   GitHub Actions

See error Some CI checks or statuses failed during the execution of the job.

ℹ️ Info

No other issues found (see more)

❄️ No new flaky tests detected

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 5ade6c1 | Docs | Datadog PR Page | Give us feedback!

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@dd-octo-sts
dd-octo-sts Bot force-pushed the easy-win/apm-lang-platform/php branch from e168d87 to 5ade6c1 Compare August 16, 2026 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants