Skip to content

[datadog_synthetics_test] Allow deletion of Synthetics test steps #3284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 15, 2025
Merged

[datadog_synthetics_test] Allow deletion of Synthetics test steps #3284

merged 2 commits into from
Oct 15, 2025

Conversation

ALenfant
Copy link
Contributor

Following https://github.com/DataDog/dogweb/pull/150819, our Synthetics test edit API endpoints now take into account empty arrays.

This PR:

  • Always sends the step arrays for Browser and Mobile tests, meaning if no steps are defined, an empty array is sent and any existing steps will be removed on apply
  • Adds tests for this edge case
  • Updates an existing test where a subtest had no steps and thus now sends an empty steps array

https://datadoghq.atlassian.net/browse/SYNTH-22099

@ALenfant ALenfant requested review from a team as code owners October 15, 2025 07:57
@HantingZhang2 HantingZhang2 changed the title [SYNTH-22099]Allow deletion of Synthetics test steps [datadog_synthetics_test] Allow deletion of Synthetics test steps Oct 15, 2025
@ALenfant
Copy link
Contributor Author

/merge

@dd-devflow-routing-codex
Copy link

dd-devflow-routing-codex bot commented Oct 15, 2025 •
edited
Loading

View all feedbacks in Devflow UI.

2025-10-15 10:07:24 UTC ℹ️ Start processing command /merge

2025-10-15 10:07:31 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 27m (p90).

2025-10-15 10:33:56 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit 8bb39ba into master Oct 15, 2025
12 checks passed
@dd-mergequeue dd-mergequeue bot deleted the antonin/send_empty_array_when_no_steps branch October 15, 2025 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@HantingZhang2 HantingZhang2 HantingZhang2 approved these changes

@fpighi fpighi fpighi approved these changes

Assignees

No one assigned

Labels

changelog/bugfix

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ALenfant @fpighi @HantingZhang2