Skip to content

Try to find Windows packages on a pipeline-ID specific folder before common folder - #1613

Merged
dd-mergequeue[bot] merged 2 commits into
mainfrom
alopez/recommit-pipeline-id-fix
Jul 9, 2025
Merged

Try to find Windows packages on a pipeline-ID specific folder before common folder#1613
dd-mergequeue[bot] merged 2 commits into
mainfrom
alopez/recommit-pipeline-id-fix

Conversation

@alopezz

@alopezz alopezz commented Jul 7, 2025

Copy link
Copy Markdown
Contributor

What does this PR do?

Re-does #1601.

Prepare test-infra-definition for a change that will provide a basic build artifact isolation on Windows, where the packages are now located in a pipeline-$CI_PIPELINE_ID directory

But it does so in a way that is safe to merge before DataDog/datadog-agent#38219 gets merged, by looking for the pipeline ID named subfolder first and falling back to the currently acceptable behavior otherwise.

Which scenarios this will impact?

Motivation

#incident-39868

Additional Notes

Tested here against main and here against DataDog/datadog-agent#38219

@alopezz
alopezz requested a review from a team as a code owner July 7, 2025 08:41
@alopezz alopezz changed the title include the pipeline ID in windows packages path (#1601) Try to find packages on a pipeline-ID specific folder before common folder Jul 7, 2025
@alopezz
alopezz force-pushed the alopez/recommit-pipeline-id-fix branch 3 times, most recently from b55b270 to 0f08341 Compare July 8, 2025 09:10
@alopezz
alopezz force-pushed the alopez/recommit-pipeline-id-fix branch from 0f08341 to 1e1ac24 Compare July 9, 2025 09:00
@alopezz alopezz changed the title Try to find packages on a pipeline-ID specific folder before common folder Try to find Windows packages on a pipeline-ID specific folder before common folder Jul 9, 2025
@alopezz

alopezz commented Jul 9, 2025

Copy link
Copy Markdown
Contributor Author

/merge

@dd-devflow-routing-codex

dd-devflow-routing-codex Bot commented Jul 9, 2025

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2025-07-09 13:01:28 UTC ℹ️ Start processing command /merge


2025-07-09 13:01:40 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 1h (p90).


2025-07-09 14:16:52 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue
dd-mergequeue Bot merged commit 31ef3e4 into main Jul 9, 2025
9 checks passed
@dd-mergequeue
dd-mergequeue Bot deleted the alopez/recommit-pipeline-id-fix branch July 9, 2025 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants