Skip to content

[GPUM]: wait for external signal to finish cuda-basic app - #1625

Merged
val06 merged 1 commit into
mainfrom
valeri.pliskin/cudaapp-wait-for-exit
Jul 16, 2025
Merged

[GPUM]: wait for external signal to finish cuda-basic app#1625
val06 merged 1 commit into
mainfrom
valeri.pliskin/cudaapp-wait-for-exit

Conversation

@val06

@val06 val06 commented Jul 16, 2025

Copy link
Copy Markdown
Contributor

What does this PR do?

adds graceful termination of the cuda-basic app only upon receiving an external signal

Which scenarios this will impact?

gpu e2e tests

Motivation

avoid race conditions when the workload finishes too fast

Additional Notes

a PR in the e2e tests in datadog-agent repo will follow

@val06
val06 requested a review from a team as a code owner July 16, 2025 12:53
@val06
val06 force-pushed the valeri.pliskin/cudaapp-wait-for-exit branch from 3fc4d25 to 7c2c39d Compare July 16, 2025 14:05
@val06

val06 commented Jul 16, 2025

Copy link
Copy Markdown
Contributor Author

/merge

@dd-devflow-routing-codex

dd-devflow-routing-codex Bot commented Jul 16, 2025

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2025-07-16 17:46:48 UTC ℹ️ Start processing command /merge


2025-07-16 17:46:55 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2025-07-16 21:35:25 UTC ⚠️ MergeQueue: This merge request was unqueued

valeri.pliskin@datadoghq.com unqueued this merge request

@val06

val06 commented Jul 16, 2025

Copy link
Copy Markdown
Contributor Author

/remove

@dd-devflow-routing-codex

dd-devflow-routing-codex Bot commented Jul 16, 2025

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2025-07-16 21:35:20 UTC ℹ️ Start processing command /remove


2025-07-16 21:35:23 UTC ℹ️ Devflow: /remove

@val06
val06 force-pushed the valeri.pliskin/cudaapp-wait-for-exit branch from 8386902 to ce98de3 Compare July 16, 2025 21:44
@val06
val06 requested a review from a team as a code owner July 16, 2025 21:44
@val06
val06 force-pushed the valeri.pliskin/cudaapp-wait-for-exit branch from ce98de3 to 7b1392e Compare July 16, 2025 22:11
@val06
val06 removed the request for review from a team July 16, 2025 22:11
@val06
val06 merged commit da01314 into main Jul 16, 2025
26 checks passed
@val06
val06 deleted the valeri.pliskin/cudaapp-wait-for-exit branch July 16, 2025 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants