MacOS support - #1679
Conversation
2f80901 to
8225861
Compare
8225861 to
4458411
Compare
71a7ab9 to
2ef6f4d
Compare
| case tifos.MacosOS: | ||
| wantedExt = ".dmg" |
There was a problem hiding this comment.
NIT: Could you add the fallthrough statement with tifos.Unknown? Like you did above
| var ( | ||
| MacOSDefault = MacOSSonoma | ||
| MacOSSonoma = NewDescriptorWithArch(MacosOS, "sonoma", ARM64Arch) | ||
| MacOSSonoma = NewDescriptor(MacosOS, "sonoma") |
There was a problem hiding this comment.
Should we define other versions such as ventura etc. ?
There was a problem hiding this comment.
Or is it an aws limitation?
There was a problem hiding this comment.
I think other version are supported, at least sequoia exists. But we can probably add them later if they are needed
| archStr = strings.ToLower(archStr) | ||
| switch archStr { | ||
| case "x86_64", "amd64", "": // Default architecture is AMD64 | ||
| case "x86_64", "amd64", "", "x86_64_mac": // Default architecture is AMD64 |
There was a problem hiding this comment.
Question: Why is the default architecture amd64? Since we have arm builds now maybe we want to change that?
There was a problem hiding this comment.
Since this function set the default for all the instances and not only Macos I think it makes sense to keep AMD64 as the default. Changing that would probably change the default architecture for all the existing tests which would be quite a big change
|
|
||
| // Optional | ||
| AvailabilityZone string // If not specified, will use first available zone | ||
| HostRecovery string // "on" or "off", defaults to "off" |
There was a problem hiding this comment.
NIT: Should we use a boolean for that?
| userData string | ||
| instanceType string | ||
| instanceProfile string | ||
| tenancy string |
There was a problem hiding this comment.
NIT: Should we declare WithTenancy?
Co-authored-by: Célian Raimbault <161456554+CelianR@users.noreply.github.com>
b6e1995 to
5ad4dcf
Compare
3 participants
What does this PR do?
Add support for MacOS instances. This PR allows to:
The goal is to create smoke tests on datadog-agent repository to make sure the macos agent can be installed.
Which scenarios this will impact?
Motivation
Additional Notes
Note that dedicated host must be running for 24 hours before they can be deleted. As a consequences we cannot delete the dedicated host with Pulumi. Pulumi will leave it not destroyed and test-infra-cleaner should be responisble for cleaning dedicated host when possible.