Skip to content

Issue#6 #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 13 commits into
base: develop
Choose a base branch
from
Open

Issue#6 #7

wants to merge 13 commits into from

Conversation

isalvadori
Copy link
Collaborator

  • Immediate component in org.avatar.himsa.dummy.data.component which creates 10 fake Patient in the db if not already there, and add to the gICS system one fake ConsentDTO for patient;
  • In org.avatar.himsa.dummy.data.component there is a gics_data folder which contains the .json to be imported into the gICS instance and a README with the instructions for the import;
  • GICSService and GICSServiceImpl in org.avatar.gics.service to add ConsentDTO and check the ids of patients who accepted a certain policy;
  • Endpoint in org.avatar.himsa.rest which retrieves all the Patient who gave their consent to a certain policy (a policy belongs to a certain domain and has a certain version, so the endpoint is something like /patient/with/consent/{domainId}/{policyId}/{policyVersion})
  • Add in the org.avatar.himsa.service.example.PatientService a corresponding method to be called from the aforementioned rest endpoint, which in turns call the GICSService to retrieve such information from the gICS system;

ilenia and others added 13 commits November 27, 2024 08:05
Signed-off-by: ilenia <ilenia@ilenia-XPS-15-9520>
Signed-off-by: ilenia <ilenia@ilenia-XPS-15-9520>
Signed-off-by: ilenia <ilenia@ilenia-XPS-15-9520>
Signed-off-by: ilenia <ilenia@ilenia-XPS-15-9520>
Signed-off-by: Mark Hoffmann <[email protected]>
Signed-off-by: ilenia <ilenia@ilenia-XPS-15-9520>
Signed-off-by: ilenia <ilenia@ilenia-XPS-15-9520>
Signed-off-by: ilenia <ilenia@ilenia-XPS-15-9520>
Signed-off-by: ilenia <ilenia@ilenia-XPS-15-9520>
added documentation and json to import in gICS instance

Signed-off-by: ilenia <ilenia@ilenia-XPS-15-9520>
Signed-off-by: ilenia <ilenia@ilenia-XPS-15-9520>
Signed-off-by: ilenia <ilenia@ilenia-XPS-15-9520>
@isalvadori isalvadori requested a review from maho7791 December 3, 2024 08:12
@@ -0,0 +1,9 @@
-library: enable-emf

javac.source: 17
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not needed inherited from build.bnd resp. dimc library

-library: enable-emf

javac.source: 17
javac.target: 17
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not needed inherited from build.bnd resp. dimc library

Copy link
Contributor

@maho7791 maho7791 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the issues.
The rest looks good. Thanks

javac.source: 17
javac.target: 17

Bundle-Version: ${project-version}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not needed inherited from build.bnd resp. dimc library

@Component(name = "GICSService", configurationPid = "GICSService", configurationPolicy = ConfigurationPolicy.REQUIRE)
public class GICSServiceImpl implements GICSService {

@Reference(target = "(&("+EMFNamespaces. EMF_MODEL_CONTENT_TYPE+"=soap)("+EMFNamespaces.EMF_MODEL_NAME+"=cm2))")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This targ binding is not needed, because you inject the cm2 package. therefore you can expect that this packge is registered. Because we register the generated EPackages after all EMF registration is done

@Reference(target = "("+EMFNamespaces.EMF_MODEL_CONTENT_TYPE+"=soap)")
EnvelopePackage soapPackage;

@Reference(target = "("+EMFNamespaces.EMF_MODEL_NAME+"=cm2)")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The target is also not needed, because you inbject the generated package. There cannot be another one with the same Java package namesspace ;-)

@Reference(target = "(&("+EMFNamespaces. EMF_MODEL_CONTENT_TYPE+"=soap)("+EMFNamespaces.EMF_MODEL_NAME+"=cm2))")
ResourceSet rs;

@Reference(target = "("+EMFNamespaces.EMF_MODEL_CONTENT_TYPE+"=soap)")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The target is also not needed, because you inbject the generated package. There cannot be another one with the same Java package namesspace ;-)

@@ -0,0 +1,17 @@
-library: enable-emf

Bundle-Version: ${project-version}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not needed, while inherited

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants