Issue#6 #7
Issue#6 #7
Conversation
Signed-off-by: ilenia <ilenia@ilenia-XPS-15-9520>
Signed-off-by: ilenia <ilenia@ilenia-XPS-15-9520>
Signed-off-by: ilenia <ilenia@ilenia-XPS-15-9520>
Signed-off-by: Mark Hoffmann <[email protected]>
…e.git into issue#4
Signed-off-by: ilenia <ilenia@ilenia-XPS-15-9520>
Signed-off-by: ilenia <ilenia@ilenia-XPS-15-9520>
Signed-off-by: ilenia <ilenia@ilenia-XPS-15-9520>
added documentation and json to import in gICS instance Signed-off-by: ilenia <ilenia@ilenia-XPS-15-9520>
Signed-off-by: ilenia <ilenia@ilenia-XPS-15-9520>
Signed-off-by: ilenia <ilenia@ilenia-XPS-15-9520>
| @@ -0,0 +1,9 @@ | |||
| -library: enable-emf | |||
|
|
|||
| javac.source: 17 | |||
There was a problem hiding this comment.
Not needed inherited from build.bnd resp. dimc library
| -library: enable-emf | ||
|
|
||
| javac.source: 17 | ||
| javac.target: 17 |
There was a problem hiding this comment.
Not needed inherited from build.bnd resp. dimc library
maho7791
left a comment
maho7791
left a comment
There was a problem hiding this comment.
Please fix the issues.
The rest looks good. Thanks
| javac.source: 17 | ||
| javac.target: 17 | ||
|
|
||
| Bundle-Version: ${project-version} |
There was a problem hiding this comment.
Not needed inherited from build.bnd resp. dimc library
| @Component(name = "GICSService", configurationPid = "GICSService", configurationPolicy = ConfigurationPolicy.REQUIRE) | ||
| public class GICSServiceImpl implements GICSService { | ||
|
|
||
| @Reference(target = "(&("+EMFNamespaces. EMF_MODEL_CONTENT_TYPE+"=soap)("+EMFNamespaces.EMF_MODEL_NAME+"=cm2))") |
There was a problem hiding this comment.
This targ binding is not needed, because you inject the cm2 package. therefore you can expect that this packge is registered. Because we register the generated EPackages after all EMF registration is done
| @Reference(target = "("+EMFNamespaces.EMF_MODEL_CONTENT_TYPE+"=soap)") | ||
| EnvelopePackage soapPackage; | ||
|
|
||
| @Reference(target = "("+EMFNamespaces.EMF_MODEL_NAME+"=cm2)") |
There was a problem hiding this comment.
The target is also not needed, because you inbject the generated package. There cannot be another one with the same Java package namesspace ;-)
| @Reference(target = "(&("+EMFNamespaces. EMF_MODEL_CONTENT_TYPE+"=soap)("+EMFNamespaces.EMF_MODEL_NAME+"=cm2))") | ||
| ResourceSet rs; | ||
|
|
||
| @Reference(target = "("+EMFNamespaces.EMF_MODEL_CONTENT_TYPE+"=soap)") |
There was a problem hiding this comment.
The target is also not needed, because you inbject the generated package. There cannot be another one with the same Java package namesspace ;-)
| @@ -0,0 +1,17 @@ | |||
| -library: enable-emf | |||
|
|
|||
| Bundle-Version: ${project-version} | |||
There was a problem hiding this comment.
Not needed, while inherited
org.avatar.himsa.dummy.data.componentwhich creates 10 fakePatientin the db if not already there, and add to the gICS system one fakeConsentDTOfor patient;org.avatar.himsa.dummy.data.componentthere is agics_datafolder which contains the.jsonto be imported into the gICS instance and aREADMEwith the instructions for the import;GICSServiceandGICSServiceImplinorg.avatar.gics.serviceto addConsentDTOand check the ids of patients who accepted a certain policy;org.avatar.himsa.restwhich retrieves all thePatientwho gave their consent to a certain policy (a policy belongs to a certain domain and has a certain version, so the endpoint is something like/patient/with/consent/{domainId}/{policyId}/{policyVersion})org.avatar.himsa.service.example.PatientServicea corresponding method to be called from the aforementioned rest endpoint, which in turns call theGICSServiceto retrieve such information from the gICS system;