Dev #324
Open
Dev #324
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
删除冗余的renderer判断
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
该PR的类型是？ (至少选择一个)
该PR是否向下兼容? (选择任一)
如果为否，请描述冲突情况:
涉及到的ISSUE:
fix #xxx[,#xxx], "xxx"为ISSUE序号)是否在Chrome浏览器下进行过测试？
如果这是一个新特性或新组件相关的PR，请提供如下信息
提交新特性或新组件前请先发起一个相关的ISSUE请求
其他信息:
原本的setAppScale方法 只对width做对比，本次修改是获取宽的比例和高的比例 ，拿到最小的值然后做transform，比如正常情况下我们的浏览器的高度有导航 栏，所以高度并不是1080，但是宽度却是1920的，所以此时 做对比 宽比是1920/1920=1 高是 小于1080的值/1080 结果小于1，所以scale 应该取高度比，如果打开了F12 则宽高比都小于1，此时需要获取最小的一个比值