[SL] Use geojson from Geoportal#192
Merged
Merged
Conversation
k-nut
force-pushed
the
saarland-geojson
branch
from
82628cd to
57fa04b
Compare
SimonMand
reviewed
Aug 22, 2025
SimonMand
reviewed
Aug 22, 2025
Collaborator
|
Very nice work.. when it's json api, its so easy for us to work 🥳 .. I just left a small renaming comment. |
k-nut
force-pushed
the
saarland-geojson
branch
from
57fa04b to
6c890e9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I contacted the operators of the geo portal in Saarland with some questions. They confirmed that there are no stable ids for the schools unfortunately but they also fixed some field types and pointed me to a dedicated geojson endpoint that they provide (available via https://geoportal.saarland.de/spatial-objects/257/collections/Staatliche_Dienste:Schulen_SL). We can use it so that we can re-use our existing geojson tooling.
I also noticed that the data actually provides more fields than our
normalizefunction previously extracted so I added those as well.