Skip to content

[BW] switch uuid fallback ids to address hashes#276

Merged
k-nut merged 2 commits intomainfrom
bw-ids
Apr 25, 2026
Merged

[BW] switch uuid fallback ids to address hashes#276
k-nut merged 2 commits intomainfrom
bw-ids

Conversation

@k-nut
Copy link
Copy Markdown
Member

@k-nut k-nut commented Apr 20, 2026

As discussed, we need a more stable fallback identifier for those schools that do not have a Dienststellennummer in Baden-Württemberg. We used to rely on the WFS uuid but those ids would change between runs. This change adds a fallback hash based on the name, address, zip and city. I think this works well enough for our use case and is easy enough to explain in the readme (so that the hashes are not completely magical to end users).

Based on the latest data, the following entries have collisions when building a hash from those values. I think they are legitimate duplicates in the source data and it would be fine for us to drop them though.

CleanShot 2026-04-20 at 14 27 58@2x

@tordans
Copy link
Copy Markdown

tordans commented Apr 22, 2026

I think they are legitimate duplicates in the source data and it would be fine for us to drop them though.

@k-nut not sure about the duplicates
For example those two look like different entities (with the same name)

@k-nut
Copy link
Copy Markdown
Member Author

k-nut commented Apr 23, 2026

Sorry, I think that was a misunderstanding. Those schools would still show up as two separate entities since they only share the name. Only schools with the same name, address, zip and city would be considered identical.

@tordans
Copy link
Copy Markdown

tordans commented Apr 24, 2026

Ah, aber dann verstehe ich den Screenshot oben nicht :-)

Diese drei mit "Farbe" im Namen https://schulabgleich.osm-verkehrswende.org/bundesland/BW?map=7.72/48.59223/10.20914&lq=farbe (dort nur in der Liste)

Die ersten zwei wären dann die gleiche Schule in den Daten, richtig? Können wir sicherstellen, dass immer die gleiche Schule "gewinnt"?

In meinem Ansatz bleiben diese eindeutig, weil ich die gerundeten Geokoordinaten mit einbeziehe. Vermutlich overkill.

Ich würde sagen: Das hier ist auf jeden Fall besser, als das alte System, also gerne mergen von meiner Seite.

@k-nut k-nut merged commit 4db8f3b into main Apr 25, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants