Conversation
@k-nut not sure about the duplicates |
Member
Author
|
Sorry, I think that was a misunderstanding. Those schools would still show up as two separate entities since they only share the name. Only schools with the same name, address, zip and city would be considered identical. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed, we need a more stable fallback identifier for those schools that do not have a Dienststellennummer in Baden-Württemberg. We used to rely on the WFS uuid but those ids would change between runs. This change adds a fallback hash based on the name, address, zip and city. I think this works well enough for our use case and is easy enough to explain in the readme (so that the hashes are not completely magical to end users).
Based on the latest data, the following entries have collisions when building a hash from those values. I think they are legitimate duplicates in the source data and it would be fine for us to drop them though.