attempt to fix incorrect page number in table of contents when footer pushes section to the next page#1834
Open
DetachHead wants to merge 1 commit into
Open
Conversation
… pushes section to the next page
DetachHead
force-pushed
the
fix-footer-page-number
branch
from
aace465 to
a27966d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #1120
i'm still trying to figure out what the fix is. i think my attempt here is at least partially correct, as it now creates an entry for both the wrong page number and the correct one:
i'm trying to just delay the rendering of the table of contents until after the correct page numbers for each section have been determined. i tried wrapping
TableOfContentin aDelayedWidgetbut that didn't seem to have any effect. any guidance would be appreciated, thanks