Fixed deadlock on macOS & added filtering of redundant layout requests#1913
Open
janiselfert wants to merge 3 commits into
Open
Fixed deadlock on macOS & added filtering of redundant layout requests#1913janiselfert wants to merge 3 commits into
janiselfert wants to merge 3 commits into
Conversation
… of redundant pdf layout requests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a critical deadlock issue in macOS printing that prevented the print dialog from working correctly in dynamic layout mode, prevents redundant onLayout calls and fixes problems with multiple windows.
Addressed issues:
1865
1875
Problem
The original implementation used
DispatchSemaphore.wait()to block the main thread while waiting for the PDF document from Flutter. However, this caused a deadlock on newer Flutter versions which use merged threads (see here).Solution
Replaced the semaphore-based blocking with RunLoop polling:
RunLoop.run(mode:before:)to keep the main thread responsiveAdditional Changes:
Layout Parameter Caching:
knowsPageRange()multiple times during the print dialog lifecycle with identical parametersonLayout()callsShared PrintJobs between plugin instances: