ios: Add fitToPage parameter to scale PDF to fit paper#1917
Open
sjg20 wants to merge 1 commit into
Open
Conversation
5 tasks
On iOS, CGContext.drawPDFPage renders at the PDF's native point size, which often doesn't match the selected paper size, resulting in content that only fills a fraction of the page. Add an opt-in fitToPage parameter that scales the PDF to fit the paper while preserving aspect ratio and centering the content. Thread the parameter through the full stack: Dart API (layoutPdf/directPrintPdf) -> platform interface -> method channel -> iOS PrintingPlugin -> PrintJob.drawPage, where it conditionally applies the scaling transform.
sjg20
force-pushed
the
fix-ios-print-scaling
branch
from
a27a193 to
2110efa
Compare
Author
|
Fixed the failing checks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On iOS, CGContext.drawPDFPage renders at the PDF's native point size,
which often doesn't match the selected paper size, resulting in content
that only fills a fraction of the page.
Add an opt-in fitToPage parameter that scales the PDF to fit the paper
while preserving aspect ratio and centering the content. Thread the
parameter through the full stack: Dart API (layoutPdf/directPrintPdf)
-> platform interface -> method channel -> iOS PrintingPlugin ->
PrintJob.drawPage, where it conditionally applies the scaling transform.
Fixes #1317