Fix threading issues in iOS and macOS printing plugin#1921
Open
jcarvalho-ptech wants to merge 7 commits into
Open
Fix threading issues in iOS and macOS printing plugin#1921jcarvalho-ptech wants to merge 7 commits into
jcarvalho-ptech wants to merge 7 commits into
Conversation
… of redundant pdf layout requests.
Fixed deadlock on macOS & added filtering of redundant layout requests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We did experience some issues while printing on different platforms, including deadlocks on MacOS/iOS, and crashes on Windows while accessing the printing properties.
This PR resolves those issues:
Ensure the printing logic runs on the main thread and utilising a RunLoop to drain the queue, to prevent the UI from freezing (the "beachball" on macOS) while waiting for the Dart layer to provide PDF data.
Ensure pdf extension doesn't get duplicated as as UIPrintInteractionController appends it automatically
Please review and consider if it's a viable contribution.