Skip to content

fix(ttf): name the offending codepoint when no glyph is available #1931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
NadeemIqbal wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(ttf): name the offending codepoint when no glyph is available #1931

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 18 additions & 1 deletion pdf/lib/src/pdf/font/ttf_writer.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,24 @@ class TtfWriter {
for (final char in chars) {
final glyphsIndex = charMap[char];
if (glyphsIndex != null) {
glyphsInfo.add(glyphsMap[glyphsIndex] ?? glyphsMap.values.first);
final glyph = glyphsMap[glyphsIndex];
if (glyph != null) {
glyphsInfo.add(glyph);
} else if (glyphsMap.isNotEmpty) {
glyphsInfo.add(glyphsMap.values.first);
} else {
// The font has no glyph reachable for [char] AND every other glyph in the
// subset has already been consumed, so `glyphsMap.values.first` would throw
// `Bad state: No element`. Surface a clearer diagnostic that names the
// offending codepoint — this is typically a font/charset mismatch
// (e.g. Arabic Presentation Forms in a font with no Presentation glyphs).
throw Exception(
"Missing glyph for character '${String.fromCharCode(char)}' "
'(U+${char.toRadixString(16).toUpperCase().padLeft(4, '0')}) '
'in font ${ttf.fontName}. Use a font that includes this codepoint, '
"or strip/normalize the character before passing it to the PDF.",
);
}
glyphsMap.remove(glyphsIndex);
}
}
Expand Down
Loading