-
Notifications
You must be signed in to change notification settings - Fork 41
Move runtime script to separate file #151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
milahu
wants to merge
53
commits into
DavHau:main
Choose a base branch
from
milahu:move-runtimeScript-to-separate-file
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d04198e
to
25b8206
Compare
d30d100
to
e564a22
Compare
90bca06
to
4e2a717
Compare
dynamic bins fail because the interpreter ld-linux-x86-64.so.2 is not available from /nix/store and we cannot do patchelf --set-interpreter '$ORIGIN/../lib/ld-linux-x86-64.so.2' so we must use static bins from pkgsStatic
f4ca387
to
46d1214
Compare
Amazing that you work on this!
Because it decreases the binary size. UPX compresses the binary and then unpacks it in memory. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #35
also:
remove
packStaticBin
=upx -9 -o $out/bin/${binName} ${binPath}
upx
has no effect on static binsupx
does not convert bins from dynamic to staticthen why is
upx
used here?fixme: reduce diff noise
fixme: reduce binary size of nix-portable from 188 back to 65 MB
todo: fix
nix-portable nix-build --help