Fixing README Docker instructions + tui.py adjustment#8
Open
0n1cOn3 wants to merge 3 commits into
Open
Conversation
0n1cOn3
commented
Dec 15, 2025
0n1cOn3
commented
Contributor
- Restores original links from ghrc registry, removes development paths.
- Removes ".local" since it is not required at all. (Cosmetic)
- tui.py, adjustment for QUIET_PRESET from 20% -> 30% due to known cooling issues with 1U servers (HD-Controller)
…ie/ilo4-fan-controller:latest. Cosmetic: removing local. in BASE_URL - not necessary at all. Adjustment: Increased QUIET_PRESENT value through one's own experiences for 1U servers.
…into dev? fail?
0n1cOn3
changed the title
0n1cOn3
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
This PR makes configuration adjustments and fixes documentation issues. The main purpose is to restore the original repository references, remove unnecessary URL suffixes, and adjust fan speed presets to address cooling issues with 1U servers.
- Increased QUIET_PRESET from 20% to 30% and NORMAL_PRESET from 35% to 40% to prevent HD controller overheating in 1U servers
- Updated README to use correct GitHub repository URLs and registry paths (ghcr.io instead of local paths)
- Removed ".local" suffix from example URL for cleaner documentation
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| tui.py | Increased fan speed presets (QUIET_PRESET and NORMAL_PRESET) to prevent overheating issues with 1U server HD controllers |
| README.md | Restored original GitHub repository links, updated Docker image references to use ghcr.io registry, and removed ".local" suffix from example URLs |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.